Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the Recall support #2245

Merged
merged 21 commits into from
Nov 7, 2024
Merged

Improve the Recall support #2245

merged 21 commits into from
Nov 7, 2024

Conversation

tian-lt
Copy link
Contributor

@tian-lt tian-lt commented Oct 30, 2024

No description provided.

@tian-lt tian-lt marked this pull request as ready for review November 5, 2024 05:28
@tian-lt tian-lt requested a review from hanzhang54 November 5, 2024 07:19
@hanzhang54
Copy link
Contributor

If the snapshot is saved in other modes except for the Standard, relaunch will crash.

@tian-lt
Copy link
Contributor Author

tian-lt commented Nov 6, 2024

If the snapshot is saved in other modes except for the Standard, relaunch will crash.

Nice catch. Fixed the unwrapping parts for optional properties.

@tian-lt tian-lt requested a review from hanzhang54 November 6, 2024 15:16
@tian-lt tian-lt requested a review from hanzhang54 November 7, 2024 07:33
@tian-lt tian-lt merged commit 80015d2 into microsoft:main Nov 7, 2024
5 checks passed
@tian-lt tian-lt deleted the u/tilia/snapshot branch November 7, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants