Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance packaging.md to include how to run, build and consume the ConsoleApp using GSF.CarbonAware library. #224

Open
1 task done
Lybecker opened this issue Dec 16, 2022 · 4 comments

Comments

@Lybecker
Copy link
Member

Contact Details

anlybeck@microsoft.com

What happened?

The ConsoleApp sample does not compile right out of the box. I would expect it to compile and guide to how to configure

client

WebAPI (Default)

Relevant log output

C:\code\carbon-aware-sdk\samples\lib-integration\ConsoleApp> dotnet run
C:\code\carbon-aware-sdk\samples\lib-integration\ConsoleApp\Program.cs(1,7): error CS0246: The type or namespace name '
GSF' could not be found (are you missing a using directive or an assembly reference?) [C:\code\carbon-aware-sdk\samples
\lib-integration\ConsoleApp\ConsoleApp.csproj]
C:\code\carbon-aware-sdk\samples\lib-integration\ConsoleApp\Program.cs(2,7): error CS0246: The type or namespace name '
GSF' could not be found (are you missing a using directive or an assembly reference?) [C:\code\carbon-aware-sdk\samples
\lib-integration\ConsoleApp\ConsoleApp.csproj]
C:\code\carbon-aware-sdk\samples\lib-integration\ConsoleApp\Program.cs(3,7): error CS0246: The type or namespace name '
GSF' could not be found (are you missing a using directive or an assembly reference?) [C:\code\carbon-aware-sdk\samples
\lib-integration\ConsoleApp\ConsoleApp.csproj]

The build failed. Fix the build errors and run again.

Code of Conduct

  • I agree to follow this project's Code of Conduct
@Lybecker Lybecker added the bug Something isn't working label Dec 16, 2022
@gfmatthews
Copy link
Member

@Lybecker - Seems like this is something to do with a misconfigured reference in the csproj of that example. As that example isn't actively in use in the library, this, shouldn't be a showstopper but it's still annoying and we should fix it.

Marking this as approved.

@pritipath pritipath self-assigned this Dec 20, 2022
@gfmatthews gfmatthews linked a pull request Dec 20, 2022 that will close this issue
6 tasks
@gfmatthews gfmatthews removed a link to a pull request Dec 20, 2022
6 tasks
@juzuluag
Copy link

juzuluag commented Jan 4, 2023

After talking to @pritipath , this is not a bug. It was by design. Please refer to the documentation on how to build and run the ConsoleApp

@Lybecker
Copy link
Member Author

Lybecker commented Jan 4, 2023

Okay. For ease of use for the consumer, I would expect to be able to compile and execute the code right away. If you do not include the project reference, make it very clear which assembly to link to

@juzuluag
Copy link

juzuluag commented Jan 4, 2023

Sounds good. We will enhance the current documentation. Thanks for the feedback.

@juzuluag juzuluag changed the title [Bug]: ConsoleApp does not compile [Bug]: Enhance packaging.md to include how to run, build and consume the ConsoleApp using GSF.CarbonAware library. Jan 4, 2023
@juzuluag juzuluag changed the title [Bug]: Enhance packaging.md to include how to run, build and consume the ConsoleApp using GSF.CarbonAware library. Enhance packaging.md to include how to run, build and consume the ConsoleApp using GSF.CarbonAware library. Jan 6, 2023
@juzuluag juzuluag removed the bug Something isn't working label Jan 6, 2023
juzuluag pushed a commit that referenced this issue Jan 24, 2023
Keep packages/lib versions consistent across projects
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants