-
Notifications
You must be signed in to change notification settings - Fork 818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Thin vertical line box drawing character U+2502 does not fill the line height #577
Comments
Hmmm. Interestingly, |
This is a fairly comprehensive (and spooky!) 🐛💀 update resolving many open issues. ### Arabic bugfixes - [x] Closes #532 👻 - Additional positional variants added - [x] Closes #535 🍂 - Corrected hamza form - [x] Closes #540 🎃 - Dot arrangement corrected - [x] Closes #541 🧹 - Was due to the use of anchors on those glyphs. These have been removed so the glyph can render as spacing. - [x] Closes #542 🌕 - This was partly due to a [bug in Harfbuzz]. It has been resolved both on the font side (through a different implementation) and in Harfbuzz. - [x] Closes #549 🦸♀️ - Design corrected - [x] Closes #555 💀 - All letter glyphs removed from Arabic Presentation form unicode slots to avoid situations where the glyphs are not behaving as expected. - [x] Related to #543 - uni0615 removed as Cascadia Arabic not intended to support Quranic ### Other bug fixes - [x] Closes #488 🔪 - Finally made the www ligature have the proper number of `w`s. - [x] Closes #436 🧟♀️ - Extended length of Powerline 'caps' to avoid situations where rounding can prevent overlap. This may cause problems if the caps are used next to one another, but that seems an unlikely scenario given what I've reviewed of Powerline styles. - [x] Closes #521 🤖 - enlarged the size of the grave character to make it more recognizable / legible in code. - [x] Closes #524 ☠️ - Added some more differentiation in stroke, and also created more space using hinting. - [x] Closes #525 🧙♂️ - tweaked the braces to be more twisty and create better differentiation from the parens. - [x] Closes #529 🧛♀️ - Changed year :P - [x] Closes #546 👹 - ij no longer masquerading as a mark. - [x] Closes #563 🧟♂️ - corrected `locl` feature for proper Serbian rendering - [x] Closes #571 🦹♀️ - corrected overshoot - [x] Closes #572 🕷 - ratio symbol added - [x] Closes #577 🍁 - shifted heights of box drawing lines to better align with block glyphs. Will reduce risk of non-joining forms under certain conditions. [bug in harfbuzz]: harfbuzz/harfbuzz#3069 (comment)
@DHowett, can we reopen this? It seems this issue was not fixed by #587. |
Additionally, I guess this might be similar to: |
Hmm, this Terminal thread seems related: microsoft/terminal#14654 I haven't been following this repo as closely, so idk if this is the most up-to-date thread on the topic |
Ping, requesting re-open @DHowett |
Re-requesting re-open @DHowett @zadjii-msft |
Addendum: I hope this is not a case of https://www.chiark.greenend.org.uk/~sgtatham/putty/wishlist/typographical-metrics.html / googlefonts/Inconsolata#35 because then it would probably be a dead end. |
If I had to guess, Putty is getting the shorter sTypo versions of the lines but rendering using the larger winAscent/winDescent values. So it is falling through the cracks so-to-speak. Many older software assumes the winAscent / winDescent values to be set tightly in coding fonts, but that isn’t the case for Cascadia. |
@ChristianGfK ahh I just saw your links. Yes I believe it is the exact same problem. I put a “trick” in to try and get around the issue but it appears that Putty’s text render respects my trick but still locks to the larger metrics. |
Alright, so that leaves this at "a future version of Putty might do this correctly" stage... |
Might also be that @DHowett has his line heights set differently? |
Line height is not configurable in Putty, yet, his Putty somehow Does It Right™. |
I'm quite surprised by that! I have no idea why. 😄 |
Let's please not get distracted by Putty. This is an issue that was introduced when Cascadia Mono font was upgraded from 2102.025 to 2106.017 and affects Windows Terminal too. |
@aaronbell @DHowett Any hope for progress here? Coming up on two years now. |
This issue does not reproduce in Windows Terminal using the new Atlas engine, soon to become the default per conversation. Probably best we categorize this as "known issue in old engines" and move on. |
will this be solved? |
As I think I mentioned previously, this issue is due to different ways that text rendering engines display text—the font is not inherently built wrong. A fix for the issue will require a breaking change to how vertical metrics work in the font. I plan to implement this fix in the next major version of the project. |
@aaronbell As mentioned earlier, this was introduced in a newer font update. Is rolling back the change on the table? Or would that break other things? |
@riverar it would, yes |
Cascadia family version
2108.26
Cascadia family variant(s)
Cascadia Mono (the version without ligatures)
Font file format(s)
.ttf (variable)
Platform
Windows 10
Other Software
No response
What happened?
Some of the box drawing characters, such as U+2588, the full cell solid block, fill up the entire vertical line space:

However, I can't find a thin, centered, vertical line that does the same. U+2502, the centered thin vertical line character from the same box drawing set, doesn't do so:

This makes terminal UI look pretty awful (for instance, TMUX vertical splits):

The text was updated successfully, but these errors were encountered: