Collect code coverage on CI #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nxtn
force-pushed
the
pipelines
branch
3 times, most recently
from
36225c0
to
9ace735
Compare
nxtn
force-pushed
the
pipelines
branch
2 times, most recently
from
5aeca24
to
85ec468
Compare
nxtn
force-pushed
the
pipelines
branch
22 times, most recently
from
d54e9b4
to
661d252
Compare
nxtn
force-pushed
the
pipelines
branch
2 times, most recently
from
c8500aa
to
4a36281
Compare
|
Any idea on the warnings produced? https://dev.azure.com/dnceng/public/_build/results?buildId=465409&view=results Do you plan to fix those after checkin? |
|
The "multiple file or directory matches were found" warnings are not problems. You can see that the ReportGenerator will merge multiple files and generate a single report per job. I plan to remove that task after integrating some other form of reports, such as Codecov. The "failure in sending the provision message" warnings are not caused by this PR. |
|
I don't feel like I'm qualified to code review this, so let's merge it and see what happens. =) I'm still on vacation until Monday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds basic code coverage collection on CI.
The Arcade SDK doesn't play well with coverage tools. This PR starts Coverlet to prepare assemblies before the tests run and stops it to calculate results after tests succeed.
There are three outstanding issues till now.
The paths in embedded PDBs of assemblies built with
DeterministicSourcePaths(which is enabled byContinuousIntegrationBuild) flag don't point to local source, so Coverlet can't tell which assembly to process. InstrumentationHelper.HasPdb always returns false for deterministic source paths coverlet-coverage/coverlet#363Azure Pipelines coverage board doesn't merge reports from different jobs. Codecov works fine on this.
There isn't the try-finally block in MSBuild, so if any test failed... :)