Skip to content

Expanded Guidelines for UX/UI Engineering #1072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

chadradams
Copy link
Contributor

Pull Request Template

What are you trying to address

  • Improved UX/UI Engineering docs with modern documentation.
  • Updated content for React best practices, and security guidance.
  • Changed the existing formatted documentation so it's scalable for different platforms for future PRs.
  • Refreshed documentation on Bootstrapping for React to include other platforms.
  • Added Table of Contents with ⚓ links for all related docs.

Checklist

READY TO PR? Use the check-list below to ensure your branch is ready for PR.

  • Changes follow the repo structure and land in the appropriate folder and section
  • No confidential information
  • No duplicated content
  • Labeled appropriately
  • This PR was reviewed by at least one subject matter expert
  • No lint check errors related to your changes

Note: You may see link check errors on pages you have not touched. This is normal, and due to either broken links or sites that reject link checker bots. The reviewer will help you get to a green state on these.

@chadradams
Copy link
Contributor Author

Hey everyone, any updates on this review?

Copy link
Member

@TessFerrandez TessFerrandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this, and apologies for not reviewing earlier - it had a similar topic as a PR that had been in draft for a long time so it fell through the cracks :(

I have approved but with some comments around TOCs that should be addressed before merging

@chadradams
Copy link
Contributor Author

@TessFerrandez Changes made.

@mtodd @tpope @sverrejoh I need one more approver. 😊

@chadradams
Copy link
Contributor Author

@shiranr - Edits made, thanks for the deep grammar check!
@TessFerrandez - Branch updated to latest. Waiting on review from @nyouens before moving forward.

Copy link
Contributor

@shiranr shiranr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution :) this is a really good content, I only have one comment.

@chadradams
Copy link
Contributor Author

Thanks @shiranr let me know if you need me to edit; we just need one more approval. @nyouens ?

@chadradams
Copy link
Contributor Author

@TessFerrandez @shiranr @nyouens - Looks like this is set to merge.

@TessFerrandez TessFerrandez merged commit 54a285d into microsoft:main Feb 12, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants