-
Notifications
You must be signed in to change notification settings - Fork 627
Expanded Guidelines for UX/UI Engineering #1072
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expanded Guidelines for UX/UI Engineering #1072
Conversation
Hey everyone, any updates on this review? |
…gineering-updates
…gineering-updates
….com/chadradams/code-with-engineering-playbook into chadradams/ux-ui-engineering-updates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this, and apologies for not reviewing earlier - it had a similar topic as a PR that had been in draft for a long time so it fell through the cracks :(
I have approved but with some comments around TOCs that should be addressed before merging
@TessFerrandez Changes made. @mtodd @tpope @sverrejoh I need one more approver. 😊 |
@shiranr - Edits made, thanks for the deep grammar check! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution :) this is a really good content, I only have one comment.
@TessFerrandez @shiranr @nyouens - Looks like this is set to merge. |
Pull Request Template
What are you trying to address
Checklist
READY TO PR? Use the check-list below to ensure your branch is ready for PR.