-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pauldorsch/reconcile dependency graph logic #1183
Pauldorsch/reconcile dependency graph logic #1183
Conversation
👋 Hi! It looks like you modified some files in the
If none of the above scenarios apply, feel free to ignore this comment 🙂 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1183 +/- ##
=======================================
- Coverage 76.2% 76.2% -0.1%
=======================================
Files 257 257
Lines 11440 11467 +27
Branches 1147 1151 +4
=======================================
+ Hits 8723 8741 +18
- Misses 2384 2394 +10
+ Partials 333 332 -1 ☔ View full report in Codecov by Sentry. |
…/github.com/microsoft/component-detection into pauldorsch/reconcile-dependency-graph-logic
This reverts commit 293a4b5.
Verify snapshots are failing due to new validation test cases being added. However, if you see the checks that ran for |
This PR has a few improvements:
extra
requirements for the legacy pip, but not for PipReport, but now we treat both the same.The
test/Microsoft.ComponentDetection.VerificationTests/resources/pip/roots/requirements.txt
file added in this PR has 30 diffs in main at the moment, all in the AddedRootId section of the experiment results. Now, it has 0 diffs.