Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote VCPKG detector to enabled by default #1203

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

grvillic
Copy link
Contributor

Summary

We have been running VCPKG detector for more than a year and after looking at its telemetry we have seen promising results and detection based on customer feedback.

Promoting to PROD detector.

@grvillic grvillic requested a review from a team as a code owner July 17, 2024 17:04
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.3%. Comparing base (024e2a5) to head (e76ec4b).

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1203     +/-   ##
=======================================
- Coverage   76.3%   76.3%   -0.1%     
=======================================
  Files        257     256      -1     
  Lines      11601   11596      -5     
  Branches    1168    1168             
=======================================
- Hits        8860    8855      -5     
  Misses      2403    2403             
  Partials     338     338             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pauld-msft pauld-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as detector version doesn't need to be updated

@grvillic grvillic merged commit 13744ee into main Jul 17, 2024
23 of 26 checks passed
@grvillic grvillic deleted the users/grvillic/PromoteVcpkgDetector branch July 17, 2024 17:50
Copy link

github-actions bot commented Jul 17, 2024

👋 Hi! It looks like you modified some files in the Detectors folder.
You may need to bump the detector versions if any of the following scenarios apply:

  • The detector detects more or fewer components than before
  • The detector generates different parent/child graph relationships than before
  • The detector generates different devDependencies values than before

If none of the above scenarios apply, feel free to ignore this comment 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants