Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MSTest Packages for test utilities #1234

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

pauld-msft
Copy link
Member

@pauld-msft pauld-msft commented Aug 23, 2024

Dotnet pack is failing, since testhost.dll is mistakenly in the TestUtilities Nuget package.

The assembly 'content\testhost.dll' is not inside the 'lib' folder and hence it won't be added as a reference when the package is installed into a project. Move it into the 'lib' folder if it needs to be referenced.

https://learn.microsoft.com/en-us/dotnet/core/testing/unit-testing-mstest-getting-started mentions

If you are creating a test infrastructure project that is intended to be used as a helper by multiple test projects, you should install the MSTest.TestFramework and MSTest.Analyzers packages directly into that project.

@pauld-msft pauld-msft requested a review from a team as a code owner August 23, 2024 19:19
Copy link

codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.9%. Comparing base (9297f05) to head (a838468).

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1234   +/-   ##
=====================================
  Coverage   88.9%   88.9%           
=====================================
  Files        359     359           
  Lines      27668   27668           
  Branches    1784    1784           
=====================================
  Hits       24610   24610           
  Misses      2674    2674           
  Partials     384     384           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pauld-msft pauld-msft merged commit 1d1e13b into main Aug 23, 2024
24 of 27 checks passed
@pauld-msft pauld-msft deleted the pauldorsch/update-mstest-packages branch August 23, 2024 19:27
Copy link

👋 Hi! It looks like you modified some files in the Detectors folder.
You may need to bump the detector versions if any of the following scenarios apply:

  • The detector detects more or fewer components than before
  • The detector generates different parent/child graph relationships than before
  • The detector generates different devDependencies values than before

If none of the above scenarios apply, feel free to ignore this comment 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants