Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Component Detection to .NET v8 #1249

Merged
merged 10 commits into from
Sep 27, 2024
Merged

Update Component Detection to .NET v8 #1249

merged 10 commits into from
Sep 27, 2024

Conversation

cobya
Copy link
Contributor

@cobya cobya commented Sep 16, 2024

Update Component Detection to .NET v8, the latest LTS branch of .NET Core. See #771 for more information.

@cobya cobya added type:feature Feature (new functionality) dependencies Pull requests that update a dependency file breaking change Breaking change, requires major version bump .NET Pull requests that update .net code labels Sep 16, 2024
@cobya cobya requested a review from a team as a code owner September 16, 2024 16:31
Copy link

codecov bot commented Sep 16, 2024

Codecov Report

Attention: Patch coverage is 95.44974% with 43 lines in your changes missing coverage. Please review.

Project coverage is 88.9%. Comparing base (8360853) to head (40b87aa).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ComponentDetection.Detectors/pip/PythonResolver.cs 28.5% 1 Missing and 4 partials ⚠️
...entDetection.Detectors/rust/CargoDependencyData.cs 0.0% 4 Missing ⚠️
...ection.Common/DependencyGraph/ComponentRecorder.cs 62.5% 2 Missing and 1 partial ⚠️
...ft.ComponentDetection.Common/PathUtilityService.cs 25.0% 0 Missing and 3 partials ⚠️
...Detection.Detectors/npm/NpmLockfileDetectorBase.cs 72.7% 3 Missing ⚠️
...entDetection.Detectors/pip/PythonCommandService.cs 50.0% 3 Missing ⚠️
...etectors/dockerfile/DockerfileComponentDetector.cs 60.0% 2 Missing ⚠️
...tDetection.Detectors/nuget/NuGetNuspecUtilities.cs 33.3% 2 Missing ⚠️
...entDetection.Detectors/pip/SimplePythonResolver.cs 75.0% 0 Missing and 2 partials ⚠️
....Common.Tests/BaseDetectionTelemetryRecordTests.cs 71.4% 1 Missing and 1 partial ⚠️
... and 14 more
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1249   +/-   ##
=====================================
  Coverage   88.9%   88.9%           
=====================================
  Files        359     359           
  Lines      27672   27643   -29     
  Branches    1784    1782    -2     
=====================================
- Hits       24613   24599   -14     
+ Misses      2674    2661   -13     
+ Partials     385     383    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cobya
Copy link
Contributor Author

cobya commented Sep 16, 2024

Dropping the SDK version back to 8.0.303 to avoid NuGet/Home#13729

Copy link

github-actions bot commented Sep 27, 2024

👋 Hi! It looks like you modified some files in the Detectors folder.
You may need to bump the detector versions if any of the following scenarios apply:

  • The detector detects more or fewer components than before
  • The detector generates different parent/child graph relationships than before
  • The detector generates different devDependencies values than before

If none of the above scenarios apply, feel free to ignore this comment 🙂

@cobya cobya merged commit 809f458 into main Sep 27, 2024
24 of 27 checks passed
@cobya cobya deleted the cobya/netv8 branch September 27, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Breaking change, requires major version bump dependencies Pull requests that update a dependency file .NET Pull requests that update .net code type:feature Feature (new functionality) version:major
Projects
Development

Successfully merging this pull request may close these issues.

2 participants