Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update syft image and doc - use docker commands #1307

Merged
merged 5 commits into from
Nov 19, 2024

Conversation

pauld-msft
Copy link
Member

@pauld-msft pauld-msft commented Nov 18, 2024

Syft image update to newest version.

Updated docs as well since Skopeo has issue with authenticating with ACR. Also, it requires WSL to be setup as there is no Windows support.
Docker tagging and push works for this scenario, so we can use that instead: containers/skopeo#1534

@pauld-msft pauld-msft requested a review from a team as a code owner November 18, 2024 17:03
@pauld-msft pauld-msft requested a review from grvillic November 18, 2024 17:03
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 3.44828% with 140 lines in your changes missing coverage. Please review.

Project coverage is 89.3%. Comparing base (7721f99) to head (906ab66).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...tDetection.Detectors/linux/Contracts/SyftOutput.cs 2.7% 140 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1307     +/-   ##
=======================================
- Coverage   89.6%   89.3%   -0.4%     
=======================================
  Files        378     378             
  Lines      29960   30076    +116     
  Branches    1840    1840             
=======================================
+ Hits       26862   26863      +1     
- Misses      2707    2821    +114     
- Partials     391     392      +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link

github-actions bot commented Nov 18, 2024

👋 Hi! It looks like you modified some files in the Detectors folder.
You may need to bump the detector versions if any of the following scenarios apply:

  • The detector detects more or fewer components than before
  • The detector generates different parent/child graph relationships than before
  • The detector generates different devDependencies values than before

If none of the above scenarios apply, feel free to ignore this comment 🙂

@pauld-msft pauld-msft changed the title Update syft doc - use docker commands Update syft image and doc - use docker commands Nov 18, 2024
Copy link
Contributor

@grvillic grvillic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's bump the linux detector version to reflect an underlying change in the detector

@pauld-msft pauld-msft merged commit 952c1ce into main Nov 19, 2024
22 of 26 checks passed
@pauld-msft pauld-msft deleted the pauldorsch/updatesyftdocs branch November 19, 2024 14:07
pauld-msft added a commit that referenced this pull request Dec 4, 2024
pauld-msft added a commit that referenced this pull request Dec 4, 2024
pauld-msft added a commit that referenced this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants