-
Notifications
You must be signed in to change notification settings - Fork 1.7k
TLS1.2 through WinHttpSetOption on winhttp_client #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I tried to weasel my way into this by setting an Adding something like There is already a platform specific callback for the ASIO based client ( Still I'd personally welcome such an extension ... Also, the functionality would be important enough (for me) to warrant an appropriate config option within |
Only 1 overloaded callback with an extra parameter to show where the handle is coming from will be sufficient:
and then call the open_session callback in the open function:
|
We definitely need APIs to allow setting options on the underlying native handles. To keep consistency with the existing callback APIs, it's probably best to add a separate api like @megaposer suggested above: It's also a good point that it's common enough to want to specify the desired protocols. It's something we can reasonably expect every underlying platform to support, so it definitely would be reasonable to have this as a first-class API. |
Any updates on this issue? |
Are you still using version 2.7? I've read with 2.10 it's able to set WINHTTP_OPTION_SECURE_PROTOCOLS to enable tls 1.1/1.2. |
I need to activate TLS1.2 in Casablanca on Windows. The only way I have found to do this is actually recompile the cpprest120_2_7.dll with the following lines in the open() function of winhttp_client:
}
This works, so far so good, but it needs recompilation of cpprest120_2_7.dll and this is surely not right way to go when it concerns future updates of the SDK.
I have also tried to use the set_nativehandle_options to do these settings so I don't have to recompile the cpprest120_2_7.dll, but unfortunately this native handle concerns only the request handle (in the send_request function) and not the session handle.
Is there any way to enable TLS1.2 without recompilation of cpprest120_2_7.dll? And if not, can also a callback function like set_nativehandle_options in the open function be implemented in the standard release of the SDK that exposes the session handle and I can use WinHttpSetOption in my own software on this session handle?
The text was updated successfully, but these errors were encountered: