Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding proxy support for token_from_code and token_from_refresh methods #1

Merged
merged 1 commit into from
Nov 5, 2015

Conversation

glukacsy
Copy link

@glukacsy glukacsy commented Oct 9, 2015

Hi,

I noticed that the token_from_code we are using in our project fails in an environment requiring proxy. The fundamental reason for this is that token_from_code under the hood instantiates a plain http_client without passing any configuration to it.

I was considering several designs how to solve this, but for simplicity I settled down on the idea of setting the proxy directly on the Oauth2 object.

Let me know if you have a different design in mind - in general I felt that the OAuth2 config is somewhat detached from the encapsulating HTTP config object. For example, if the OAuth2 config object knew about the parent HTTP config object it would be able to pull the proxy (and other things if needed) from the parent. I was just not sure about the design intent here and didn't want to propose a bigger structural change.

Regards,
Gergely

@kavyako
Copy link
Contributor

kavyako commented Nov 2, 2015

hey glukacsy

Sorry for our delayed response.
The changes look good. To contribute to the project, you will need to sign our contributor license agreement (CLA). Once you've signed you can email it directly to me at kavyako at Microsoft dot com or askcasablanca at Microsoft dot com.

Thanks
Kavya.

@glukacsy
Copy link
Author

glukacsy commented Nov 5, 2015

Hey, I have emailed you the CLA, thank you very much!

kavyako added a commit that referenced this pull request Nov 5, 2015
Adding proxy support for token_from_code and token_from_refresh methods
@kavyako kavyako merged commit 40757be into microsoft:development Nov 5, 2015
AnyCPU added a commit to AnyCPU/cpprestsdk that referenced this pull request Dec 22, 2015
xqp pushed a commit to xqp/cpprestsdk that referenced this pull request Apr 5, 2018
FIX: Certificate Pinning Compilation on Linux
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants