-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding proxy support for token_from_code and token_from_refresh methods #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hey glukacsy Sorry for our delayed response. Thanks |
Hey, I have emailed you the CLA, thank you very much! |
kavyako
added a commit
that referenced
this pull request
Nov 5, 2015
Adding proxy support for token_from_code and token_from_refresh methods
AnyCPU
added a commit
to AnyCPU/cpprestsdk
that referenced
this pull request
Dec 22, 2015
xqp
pushed a commit
to xqp/cpprestsdk
that referenced
this pull request
Apr 5, 2018
FIX: Certificate Pinning Compilation on Linux
ghost
mentioned this pull request
Apr 19, 2019
This was referenced Dec 27, 2019
GerHobbelt
pushed a commit
to GerHobbelt/cpprestsdk
that referenced
this pull request
Jun 21, 2024
Fix build issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I noticed that the token_from_code we are using in our project fails in an environment requiring proxy. The fundamental reason for this is that token_from_code under the hood instantiates a plain http_client without passing any configuration to it.
I was considering several designs how to solve this, but for simplicity I settled down on the idea of setting the proxy directly on the Oauth2 object.
Let me know if you have a different design in mind - in general I felt that the OAuth2 config is somewhat detached from the encapsulating HTTP config object. For example, if the OAuth2 config object knew about the parent HTTP config object it would be able to pull the proxy (and other things if needed) from the parent. I was just not sure about the design intent here and didn't want to propose a bigger structural change.
Regards,
Gergely