Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

returning std::move causing build failure on osx #140

Closed
wants to merge 1 commit into from
Closed

returning std::move causing build failure on osx #140

wants to merge 1 commit into from

Conversation

rharriso
Copy link

build failed with clang on osx:

clang --version
Apple LLVM version 7.3.0 (clang-703.0.29)
Target: x86_64-apple-darwin15.4.0
Thread model: posix
InstalledDir:
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin

6 tests failed, unable to test against master:

**** outside_tests:outside_google_dot_com FAILED ****

**** outside_tests:multiple_https_requests FAILED ****

**** outside_tests:reading_google_stream FAILED ****

**** outside_tests:server_hostname_mismatch FAILED ****

**** outside_tests:outside_ssl_json FAILED ****

**** authentication_tests:hostname_mismatch FAILED ****

Finished running all 777 tests.
Took 220217ms

clang --version
Apple LLVM version 7.3.0 (clang-703.0.29)
Target: x86_64-apple-darwin15.4.0
Thread model: posix
InstalledDir:
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
@msftclas
Copy link

Hi @rharriso, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@rharriso
Copy link
Author

addresses issue #138

@ras0219-msft
Copy link
Contributor

Please make this PR against the development branch.

@msftclas
Copy link

Hi @rharriso, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@rharriso
Copy link
Author

@ras0219-msft, the development branch builds fine on osx. I was able to build and run the test successfully.

@msftclas
Copy link

msftclas commented May 2, 2016

@rharriso, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, MSBOT;

@ras0219-msft
Copy link
Contributor

Ok, I'll close this as "fixed in development branch". (If I misinterpreted your statement, please reopen it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants