Skip to content

Updating websocketpp to 6.0-permessage-deflate #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

AntonBikineev
Copy link
Contributor

Preliminary addressing #33 issue

@msftclas
Copy link

Hi @AntonBikineev, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by Microsoft and real humans are currently evaluating your PR.

TTYL, MSBOT;

@alexkaratarakis
Copy link
Contributor

Hi Anton,
I did a diff of the code in the PR with the code found here:
https://github.com/zaphoyd/websocketpp/releases/tag/0.6.0-permessage-deflate

Apart from the change in the second commit of this PR (78bae21), there are the following differences.

The pull request has this extra file:
Release\libs\websocketpp\websocketpp\error_container.hpp

The official (pre-)release has these extra files:
websocketpp-0.6.0-permessage-deflate\test\http\a.out
websocketpp-0.6.0-permessage-deflate\test\http\perf.out
websocketpp-0.6.0-permessage-deflate\test\http\test.out
websocketpp-0.6.0-permessage-deflate\cmake\CMakeHelpers.cmake

And the only different file is:
websocketpp-0.6.0-permessage-deflate.travis.yml

where the official one installs libboost-chrono1.48-dev in addition to other boost1.48 stuff, but the one in the pull request doesn’t.

Can you briefly explain the changes you made (other than the 78bae21 which is explained in the commit message)? Thanks!

@AntonBikineev
Copy link
Contributor Author

@danimoth
Hi Alexander,

First, thanks for response.

Release\libs\websocketpp\websocketpp\error_container.hpp
This file seems to be a leftover from previous version. My bad that I didn't check for removed files in new version.

All *.out files were ignored by my .gitignore (but having them in repo tree doesn't seem to be needed). CMakeHelpers.cmake was ignored too, but not sure whether it is really used. Will add to the PR anyway.

The same for .travis.

Thanks for all points.

@ras0219-msft
Copy link
Contributor

We noticed that websocketpp 0.7.0 released, so we're going to try to update to that one instead.

https://github.com/zaphoyd/websocketpp/releases

@ras0219-msft
Copy link
Contributor

We now support using an external websocketpp which can be independently upgraded (searched for via find_package(WEBSOCKETPP CONFIG)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants