Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure we update the response files when the targets are run. #445

Merged
merged 5 commits into from
Dec 18, 2019

Conversation

jlaanstra
Copy link
Contributor

@jlaanstra jlaanstra commented Dec 7, 2019

This PR makes sure that the Outputs of the various targets are updated when the targets run, to make sure the Outputs are newer than the Inputs after the target has ran.

/cc @rainersigwald to make sure I understand MSBuild's incremental build logic correctly.

Fixes #444

@jlaanstra jlaanstra requested a review from Scottj1s December 7, 2019 23:51
@jlaanstra jlaanstra added the bug label Dec 7, 2019
nuget/Microsoft.Windows.CppWinRT.targets Show resolved Hide resolved
nuget/Microsoft.Windows.CppWinRT.targets Outdated Show resolved Hide resolved
@kennykerr kennykerr merged commit e75e51b into microsoft:master Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

C++/WinRT build targets don't play well with incremental builds.
3 participants