Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

os.setsid() potentially fails in adapter/__main__.py if attaching to session leader remotely #1081

Closed
fecjanky opened this issue Oct 10, 2022 · 0 comments
Closed

os.setsid() potentially fails in adapter/__main__.py if attaching to session leader remotely #1081

fecjanky opened this issue Oct 10, 2022 · 0 comments

Comments

@fecjanky
Copy link
Contributor

Environment data

  • debugpy version: 1.6.3
  • OS and version: CentOS 8
  • Python version (& distribution if applicable, e.g. Anaconda): python3.9
  • Using VS Code or Visual Studio: vscode

Actual behavior

Debugger client connection times out

Expected behavior

Debugger client can successfully attach to injected debugpy server

Steps to reproduce:

  1. launch a python program with setsid python ....
  2. Attach to it using a remote configuration from vscode, check stderr when attaching to see the actual error message
fecjanky added a commit to fecjanky/debugpy that referenced this issue Oct 10, 2022
@fecjanky
Fix microsoft#1081: no need to call os.setsid() on session leader whe…
51c2e81 
…n attaching

If os.setsid() raises exception then the debugger client
won't be able to attach to the remote process
@int19h int19h closed this as completed in 46efd10 Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fecjanky