Stop Debugging in a "noDebug" session doesn't kill subprocesses

[kenmillar253]

VSCode Version: 1.42.1

OS Version: Ubuntu 18.04

Steps to Reproduce:

• Comment "--noreload" in launch.json
• Press Ctrl + F5 to run the django process.
• Click "stop(Shift + F5)" button to stop all django processes.
• But there is still a process (pid 23069) that has not been closed.
• And its parent process become 1 from 23064

[kenmillar253]

Sorry, I posted the wrong place

[karthiknadig]

@kenmillar253 I moved this issue from python extension repo to the debugger repo. This issue should be looked at by the debugger first.

[kenmillar253]

@kenmillar253 I moved this issue from python extension repo to the debugger repo. This issue should be looked at by the debugger first.
Oh! I misunderstood your meaning, thanks!

[int19h]

This is probably #3

[kenmillar253]

This is probably microsoft/debugpy#3

Hi @int19h , I have check this link #3.
Then install debugpy-1.0.0b3, ptvsd-5.0.0a12 and pydevd-1.9.0
The child process is still not auto-kill.

As you mentioned, how can I set launch.json to perform its own cleanup? Which args?

[karthiknadig]

@kenmillar253 don't install debugpy, ptvsd, or pydevd. This does not matter, since you are using launch configuration, the python extension will pick the debugger for you. Follow the instructions here to get the right debugger:
#59

[kenmillar253]

@karthiknadig I have install this dev vsix now.
And when this parameter --noreload is added, there will be 2 processes, all child processes can be closed. But when comment it, there will be 3 processes, only two of them were killed.

[kenmillar253]

[int19h]

If you do import ptvsd; print(ptvsd.__version__) at the beginning of your code, what does it print?

[kenmillar253]

@int19h It print 5.0.0a12

There is one child process not closed with its parent pid become 1

[int19h]

Mystery solved - the reason why I couldn't repro is because I didn't notice that you were using Ctrl+F5 (i.e. running without debugging).

The problem is that when we're not debugging, we're also not able to detect subprocesses. So when you stop the no-debug session, we kill the parent Django process, but not the child process that it had spawned.

We'll need to add some special cleanup to the launcher to kill the entire process tree in this scenario.