Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compute breakpoint frame name if not passed #51

Closed
fabioz opened this issue Feb 20, 2020 · 0 comments
Closed

Compute breakpoint frame name if not passed #51

fabioz opened this issue Feb 20, 2020 · 0 comments
Assignees
@fabioz

Comments

@fabioz
Copy link
Collaborator

fabioz commented Feb 20, 2020

One important optimization is that pydevd can skip tracing completely for frames if the frames does not have a breakpoint.

This is only working partially when using the DAP with pydevd because the function name is not being passed (so, it will only completely skip a context if there's no breakpoint in the file, not in a particular frame).

To fix this, when using the DAP it should load the file, get the AST and compute the frame name.
@fabioz fabioz mentioned this issue Feb 20, 2020
Closed
@fabioz fabioz changed the title [Performance] Compute breakpoint frame name if not passed Compute breakpoint frame name if not passed Feb 20, 2020
@fabioz fabioz self-assigned this Feb 20, 2020
fabioz added a commit to fabioz/debugpy that referenced this issue Mar 6, 2020
@fabioz
Skip functions considering lines instead of function name. Fixes micr…
1e97c12 
…osoft#51
fabioz added a commit to fabioz/debugpy that referenced this issue Mar 6, 2020
@fabioz
Skip functions considering lines instead of function name. Fixes micr…
0b600f8 
…osoft#51
@fabioz fabioz closed this as completed in 198cc57 Mar 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fabioz fabioz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fabioz