Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flask tests fail because werkzeug.server.shutdown is deprecated #628

Closed
fabioz opened this issue May 21, 2021 · 1 comment
Closed

Flask tests fail because werkzeug.server.shutdown is deprecated #628

fabioz opened this issue May 21, 2021 · 1 comment
Assignees
@int19h
Labels
test issue Test failures and other issues with test runs and CI.

Comments

@fabioz
Copy link
Collaborator

fabioz commented May 21, 2021

Flask 2.0 should not break the related tests in the debugger.
@int19h int19h self-assigned this May 25, 2021
@int19h int19h added the test issue Test failures and other issues with test runs and CI. label May 25, 2021
@int19h
Copy link
Contributor

int19h commented May 25, 2021

It happens because we're using request.environ.get("werkzeug.server.shutdown") to clean up the Flask server in the tests, which is now deprecated and raises a warning.

@int19h int19h changed the title Investigate test failures with flask 2.0 Flask tests fail because werkzeug.server.shutdown is deprecated May 25, 2021
int19h added a commit to int19h/debugpy that referenced this issue May 25, 2021
@int19h
Fix microsoft#628: Flask tests fail because werkzeug.server.shutdown …
6f138a4 
…is deprecated

Use @app.teardown_request to exit asynchronously after serving the response.
@int19h int19h closed this as completed in 0a7f2cd May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@int19h int19h

Labels
test issue Test failures and other issues with test runs and CI.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fabioz @int19h