Fix pyqt6 loader on windows #1797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchiodo
commented
Jan 6, 2025
| and submod_finder.find_spec("QtGui") is not None | ||
| and submod_finder.find_spec("QtSvg") is not None | ||
| ) | ||
| try: |
There was a problem hiding this comment.
This code was trying to load PyQt4 twice, when PyQt4 doesn't even exist anymore (at least on windows)
There was a problem hiding this comment.
If it fails to load the main module, it should just return False.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was testing matplotlib after a submission this morning and I needed this change for the QT backend to work.