-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tooltips for exception breakpoint filters. (#790) #798
Conversation
{ | ||
"filter": "userUnhandled", | ||
"label": "User Uncaught Exceptions", | ||
"default": False, | ||
"description": "Break when exception escapes into library code.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@luabud @brettcannon For input on the text being used for various exception breakpoint.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"description": "Break when exception escapes into library code.", | |
"description": "Break when an exception escapes into library code.", |
Maybe "3rd-party" instead of "library"? No real opinion honestly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It has always been a tricky one to name concisely. The only baseline that we have here is "just my code" as the name of the related breakpoint feature. But it's basically "stdlib + site-packages" by default, and there are also ways to customize it. So "third-party" is not necessarily accurate if there are some first-party dependencies that just happen to be installed into site-packages (including venv).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"non-user code" maybe? But also no preference here 😅 library code is also fine as is. a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Non-user code" is where I started, but then it's kinda redundant wrt the option name; so I wanted the tooltip to give more clues as to what "non-user" actually means.
The other thing is that "user code" makes sense to us, but less so to the actual user - to them, it's "my code"! E.g. consider "just my code" vs "user-code only"... the catch here is that we label the option itself "User uncaught exceptions", so it's already wrong in this sense, tooltip or no tooltip. But we could rename it to "Exceptions not caught in my code" or something like that?
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
No description provided.