Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add automatic conversion from string to int/float type #921

Merged
merged 7 commits into from
May 2, 2022
Merged

add automatic conversion from string to int/float type #921

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e5c84d0
add automatic conversion from string to int/float type, during type c…
giaco5988 Apr 27, 2022
98a830b
re-format with black
giaco5988 Apr 27, 2022
32f6462
more flexible logic that try converting str to number with all classi…
giaco5988 Apr 28, 2022
4e71f01
add tests for string to nums conversion during json parsing
giaco5988 Apr 28, 2022
9d8e709
re-format with black
giaco5988 Apr 28, 2022
2c2efbc
no need to use f-string
giaco5988 Apr 28, 2022
b3cc74b
improve code readability for sonarcloud checks
giaco5988 Apr 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/debugpy/common/json.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@
import builtins
import json
import operator
import string
import numbers


JsonDecoder = json.JSONDecoder
Expand Down Expand Up @@ -106,6 +108,15 @@ def of_type(*classinfo, **kwargs):
def validate(value):
if (optional and value == ()) or isinstance(value, classinfo):
return value
elif (
isinstance(value, str)
and all(x in string.digits + "." for x in value)
giaco5988 marked this conversation as resolved.
Show resolved Hide resolved
and any(issubclass(x, numbers.Number) for x in classinfo)
):
try:
return int(value)
except ValueError:
return float(value)
giaco5988 marked this conversation as resolved.
Show resolved Hide resolved
else:
if not optional and value == ():
raise ValueError("must be specified")
Expand Down