Failed to parse key="value" in an override such as secret when secret is containing equal sign

[sebbrochet]

Hello,

Code in InplaceOverride method in https://github.com/microsoft/delta-kusto/blob/main/code/DeltaKustoIntegration/Parameterization/ParameterOverrideHelper.cs is checking for the proper number of equal signs in an override but doesn't properly support the value containing an equal sign by itself and throws an error:

public static void InplaceOverride(object target, IEnumerable<string> pathOverrides)
        {
            if (pathOverrides.Any())
            {
                try
                {
                    var splits = pathOverrides.Select(t => t.Split('='));
                    var noEquals = splits.FirstOrDefault(s => s.Length != 2);

                    if (noEquals != null)
                    {
                        throw new DeltaException(
                            $"Override must be of the form path=value ; "
                            + $"exception:  '{string.Join('=', noEquals)}'");
                    }

So, let's say you want to override the secret parameter and the secret is containing an equal sign, it'll break:

Activating Client...                                                                                                                                                                    
Client Activated                                                                                                                                                                        
Newer clients available:  0.10.2.109                                                                                                                                                    
Loading parameters at 'C:\XXX\rev-engineer-parameters.yaml'                                                                                    
Error:  Issue with the following parameter override:  'System.String[]'                                                                                                                 
  Error:  Override must be of the form path=value ; exception:  'tokenProvider.login.secret=LXXXXX4='                                               
  Exception encountered:  DeltaKustoLib.DeltaException ; Override must be of the form path=value ; exception:  'tokenProvider.login.secret=LXXXXX4='
  Stack trace:     at DeltaKustoIntegration.Parameterization.ParameterOverrideHelper.InplaceOverride(Object target, IEnumerable`1 pathOverrides)

Whereas what is passed is: tokenProvider.login.secret="LXXXXX4="
Which should be considered as a valid key/value override.

[sebbrochet]

OK, managed to work around it by building a local version of the tool with below change:

using System.Text.RegularExpressions;

...

public static void InplaceOverride(object target, IEnumerable<string> pathOverrides)
{
    if (pathOverrides.Any())
    {
        try
        {                                        
            var regExStr = @"(?<path>.+)=(?<textValue>.+)";                    
            var regEx = new Regex(regExStr, RegexOptions.Compiled); 
            var splits = pathOverrides.Select(s => regEx.Match(s)).Where(m => m.Success);
            var overrides = splits.Select(m => (path: m.Groups[1].Value, textValue: m.Groups[2].Value));
            InplaceOverride(target, overrides);                    
        }
        catch (Exception ex)
        {
            throw new DeltaException(
                $"Issue with the following parameter override:  '{pathOverrides}'",
                ex);
        }
    }
}

[vplauzon]

Good catch. Fixed in 0.10.3.