Skip to content

Conversation

@anandbonde
Copy link
Contributor

@anandbonde anandbonde commented Apr 15, 2025

Upgraded the nightly build version and found that some explicit attributes are stable now, so they are no longer needed in the code. So I removed them. There should be no impact on the functionality and performance of the code.

This is the latest version which works fine with Linux Catpowder; further versions don't pass tests. Will investigate and address this if needed in a separate PR.

@anandbonde anandbonde requested review from Copilot and iyzhang April 15, 2025 02:48
@anandbonde anandbonde self-assigned this Apr 15, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • rust-toolchain: Language not supported

@github-actions
Copy link

libos = catnip
commit id = a861628

collapsed_stack num_calls cycles_per_call nanoseconds_per_call total_duration percent_total_duration total_duration_exclusive percent_total_duration_exclusive
bgc::inetstack::poll;inetstack::layer4::poll_once;catnip::runtime::receive 5530694 207 83 1133881747 19 1133881747 43
bgc::inetstack::poll;inetstack::layer4::poll_once 5530694 384 154 2085954368 35 947239146 36
bgc::inetstack::poll 2765347 957 384 2607670579 44 521716211 20
ioc::network::libos::push 16145 1337 545 17774296 0 15694902 1
ioc::network::libos::pushto 6204 1274 528 7617773 0 6387169 0
bgc::inetstack::poll;inetstack::layer4::poll_once;inetstack::layer4::receive_batch 2556 3336 1313 4916810 0 4905460 0
bgc::inetstack::tcp::established::background;tcp::established::background::retransmitter 11059 323 130 4207161 0 4206205 0
ioc::network::libos::pop 9195 444 176 2884902 0 2884902 0
bgc::inetstack::tcp::established::background 11070 1217 482 10331497 0 2819118 0
bgc::inetstack::tcp::established::background;tcp::established::background::acknowledger 11070 446 175 2646162 0 2642582 0
ioc::network::libos::push;catnip::runtime::transmit 8763 376 153 2257628 0 2257628 0
ioc::network::libos::connect 42 33340 13202 1360100 0 1303745 0
ioc::network::libos::pushto;catnip::runtime::transmit 6204 214 89 1230604 0 1230604 0
demikernel::sgaalloc 6954 169 68 733786 0 733786 0
demikernel::sgafree 9116 93 38 665578 0 665578 0
bgc::inetstack::tcp::established::background;tcp::established::background::sender 11017 324 125 659055 0 648815 0
bgc::inetstack::tcp::passiveopen::background 42 24662 9951 587516 0 539949 0
ioc::network::libos::connect;catnip::runtime::transmit 42 6507 2534 56355 0 56355 0
ioc::network::libos::close 50 2372 946 55298 0 55298 0
bgc::inetstack::tcp::passiveopen::background;catnip::runtime::transmit 21 13732 5557 47566 0 47566 0
ioc::network::libos::accept 37 2173 880 45601 0 45601 0
bgc::inetstack::tcp::established::background;tcp::established::background::acknowledger;catnip::runtime::transmit 14 2866 1178 22277 0 22277 0
bgc::inetstack::poll;inetstack::layer4::poll_once;inetstack::layer4::receive_batch;udp::receive 84 240 98 20540 0 20540 0
bgc::inetstack::poll;inetstack::layer4::poll_once;inetstack::layer4::receive_batch;catnip::runtime::transmit 23 589 236 11022 0 11022 0
bgc::inetstack::tcp::established::background;tcp::established::background::sender;catnip::runtime::transmit 21 591 236 10241 0 10241 0
bgc::inetstack::arp::background 2 3256 1303 8299 0 8299 0
bgc::inetstack::tcp::established::background;tcp::established::background::retransmitter;catnip::runtime::transmit 15 743 310 6692 0 6692 0
bgc::inetstack::icmp::background 1 1782 713 1888 0 1888 0

@github-actions
Copy link

libos = catnap
commit id = a861628

collapsed_stack num_calls cycles_per_call nanoseconds_per_call total_duration percent_total_duration total_duration_exclusive percent_total_duration_exclusive
bgc::catnap::transport::epoll 10851044 3990 1665 5683355290 100 5683355290 100
ioc::network::libos::push 17600 494 203 7384546 0 7384546 0
ioc::network::libos::pop 15054 710 297 5539334 0 5539334 0
ioc::network::libos::connect 50 163003 65621 2886490 0 2886490 0
ioc::network::libos::accept 26 112110 46688 1408841 0 1408841 0
demikernel::sgaalloc 11287 122 50 1184768 0 1184768 0
demikernel::sgafree 11538 72 30 715656 0 715656 0
ioc::network::libos::pushto 1333 329 126 433149 0 433149 0
ioc::network::libos::close 18 22938 9431 330978 0 330978 0

@anandbonde anandbonde marked this pull request as draft April 15, 2025 04:17
@anandbonde anandbonde force-pushed the anandbonde/upgrade-rust-version branch from a861628 to 7af88be Compare April 15, 2025 04:40
@anandbonde anandbonde marked this pull request as ready for review April 15, 2025 04:40
@github-actions
Copy link

libos = catnap
commit id = 7af88be

collapsed_stack num_calls cycles_per_call nanoseconds_per_call total_duration percent_total_duration total_duration_exclusive percent_total_duration_exclusive
bgc::catnap::transport::epoll 11020117 3649 1600 5809932525 100 5809932525 100
ioc::network::libos::push 17600 504 208 7495617 0 7495617 0
ioc::network::libos::pop 15235 487 201 5355239 0 5355239 0
ioc::network::libos::connect 50 168002 66309 2969799 0 2969799 0
ioc::network::libos::accept 26 108367 44908 1349561 0 1349561 0
demikernel::sgaalloc 11306 151 62 1104280 0 1104280 0
demikernel::sgafree 11544 70 29 679145 0 679145 0
ioc::network::libos::pushto 1823 323 133 585072 0 585072 0
ioc::network::libos::close 18 22476 9274 331476 0 331476 0

@github-actions
Copy link

libos = catnip
commit id = 7af88be

collapsed_stack num_calls cycles_per_call nanoseconds_per_call total_duration percent_total_duration total_duration_exclusive percent_total_duration_exclusive
bgc::inetstack::poll;inetstack::layer4::poll_once;catnip::runtime::receive 24545823 207 83 4966056473 20 4966056473 44
bgc::inetstack::poll;inetstack::layer4::poll_once 24545823 384 154 9101136388 36 4130134930 36
bgc::inetstack::poll 12272912 959 384 11292449869 44 2191313481 19
ioc::network::libos::push 16145 1218 496 17462083 0 15378549 0
bgc::inetstack::poll;inetstack::layer4::poll_once;inetstack::layer4::receive_batch 2424 4190 1653 5028798 0 5013907 0
bgc::inetstack::tcp::established::background;tcp::established::background::retransmitter 11060 311 125 4250183 0 4249041 0
bgc::inetstack::tcp::established::background 11071 1105 438 10357854 0 2821150 0
ioc::network::libos::pop 9035 399 160 2777729 0 2777729 0
bgc::inetstack::tcp::established::background;tcp::established::background::acknowledger 11071 366 145 2618440 0 2615421 0
ioc::network::libos::push;catnip::runtime::transmit 8763 338 138 2262122 0 2262122 0
ioc::network::libos::connect 42 34043 13838 1389820 0 1332462 0
ioc::network::libos::pushto 1027 1366 573 1403090 0 1138945 0
demikernel::sgaalloc 6522 146 60 781316 0 781316 0
bgc::inetstack::tcp::established::background;tcp::established::background::sender 11017 309 119 668081 0 658215 0
demikernel::sgafree 8768 86 35 650548 0 650548 0
bgc::inetstack::tcp::passiveopen::background 42 23817 9583 523871 0 473375 0
ioc::network::libos::pushto;catnip::runtime::transmit 1027 257 108 264145 0 264145 0
bgc::inetstack::poll;inetstack::layer4::poll_once;inetstack::layer4::receive_batch;udp::receive 401 232 97 84371 0 84371 0
ioc::network::libos::connect;catnip::runtime::transmit 42 6634 2681 57358 0 57358 0
ioc::network::libos::close 49 2575 1046 56011 0 56011 0
bgc::inetstack::tcp::passiveopen::background;catnip::runtime::transmit 21 15170 6156 50496 0 50496 0
ioc::network::libos::accept 37 2201 886 46028 0 46028 0
bgc::inetstack::arp::background 7 3401 1362 23121 0 23121 0
bgc::inetstack::tcp::established::background;tcp::established::background::acknowledger;catnip::runtime::transmit 17 1420 586 18783 0 18783 0
bgc::inetstack::poll;inetstack::layer4::poll_once;inetstack::layer4::receive_batch;catnip::runtime::transmit 24 570 229 11170 0 11170 0
bgc::inetstack::tcp::established::background;tcp::established::background::sender;catnip::runtime::transmit 21 577 232 9866 0 9866 0
bgc::inetstack::tcp::established::background;tcp::established::background::retransmitter;catnip::runtime::transmit 15 579 243 7106 0 7106 0
bgc::inetstack::icmp::background 1 1833 734 1976 0 1976 0

Copy link
Contributor

@iyzhang iyzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this

@anandbonde anandbonde force-pushed the anandbonde/upgrade-rust-version branch from 7af88be to 9869199 Compare April 17, 2025 18:35
@github-actions
Copy link

libos = catnip
commit id = 9869199

collapsed_stack num_calls cycles_per_call nanoseconds_per_call total_duration percent_total_duration total_duration_exclusive percent_total_duration_exclusive
bgc::inetstack::poll;inetstack::layer4::poll_once;catnip::runtime::receive 5515019 209 84 1149572869 19 1149572869 42
bgc::inetstack::poll;inetstack::layer4::poll_once 5515019 389 157 2121468605 35 967098861 36
bgc::inetstack::poll 2757510 975 392 2667562663 44 546094058 20
ioc::network::libos::push 16145 1246 514 17571681 0 15516961 1
ioc::network::libos::pushto 4867 1326 540 6060200 0 5026987 0
bgc::inetstack::poll;inetstack::layer4::poll_once;inetstack::layer4::receive_batch 2503 3885 1542 4879581 0 4868176 0
bgc::inetstack::tcp::established::background;tcp::established::background::retransmitter 11064 323 130 4233404 0 4231935 0
ioc::network::libos::pop 9196 433 173 2942284 0 2942284 0
bgc::inetstack::tcp::established::background 11075 1147 460 10287584 0 2761809 0
bgc::inetstack::tcp::established::background;tcp::established::background::acknowledger 11075 396 159 2630415 0 2627035 0
ioc::network::libos::push;catnip::runtime::transmit 8763 339 140 2230840 0 2230840 0
ioc::network::libos::connect 42 34683 14094 1417534 0 1361535 0
ioc::network::libos::pushto;catnip::runtime::transmit 4867 234 96 1033213 0 1033213 0
demikernel::sgaalloc 6842 170 70 848397 0 848397 0
demikernel::sgafree 9065 97 39 695168 0 695168 0
bgc::inetstack::tcp::established::background;tcp::established::background::sender 11021 314 122 661955 0 652703 0
bgc::inetstack::tcp::passiveopen::background 42 24926 9984 591181 0 538109 0
ioc::network::libos::close 50 2499 1016 56083 0 56083 0
ioc::network::libos::connect;catnip::runtime::transmit 42 6389 2644 55998 0 55998 0
bgc::inetstack::tcp::passiveopen::background;catnip::runtime::transmit 21 14839 5959 53072 0 53072 0
ioc::network::libos::accept 37 2265 909 49477 0 49477 0
bgc::inetstack::poll;inetstack::layer4::poll_once;inetstack::layer4::receive_batch;udp::receive 80 269 102 21201 0 21201 0
bgc::inetstack::tcp::established::background;tcp::established::background::acknowledger;catnip::runtime::transmit 15 1924 778 17211 0 17211 0
bgc::inetstack::poll;inetstack::layer4::poll_once;inetstack::layer4::receive_batch;catnip::runtime::transmit 24 575 232 11054 0 11054 0
bgc::inetstack::arp::background 2 4356 1752 9955 0 9955 0
bgc::inetstack::tcp::established::background;tcp::established::background::sender;catnip::runtime::transmit 21 592 239 9252 0 9252 0
bgc::inetstack::tcp::established::background;tcp::established::background::retransmitter;catnip::runtime::transmit 17 1148 458 7481 0 7481 0
bgc::inetstack::icmp::background 1 2696 1104 2795 0 2795 0

@github-actions
Copy link

libos = catnap
commit id = 9869199

collapsed_stack num_calls cycles_per_call nanoseconds_per_call total_duration percent_total_duration total_duration_exclusive percent_total_duration_exclusive
bgc::catnap::transport::epoll 10984196 3745 1584 5815610018 100 5815610018 100
ioc::network::libos::push 17600 505 209 7493419 0 7493419 0
ioc::network::libos::pop 15136 493 204 5538887 0 5538887 0
ioc::network::libos::connect 50 182767 74385 3154608 0 3154608 0
ioc::network::libos::accept 26 116070 48026 1415779 0 1415779 0
demikernel::sgaalloc 11308 126 52 1104139 0 1104139 0
ioc::network::libos::pushto 2210 369 153 809021 0 809021 0
demikernel::sgafree 11549 79 33 699703 0 699703 0
ioc::network::libos::close 18 24322 10060 346552 0 346552 0

@anandbonde anandbonde force-pushed the anandbonde/upgrade-rust-version branch from 9869199 to 4f59f3a Compare April 19, 2025 19:26
@github-actions
Copy link

libos = catnap
commit id = 4f59f3a

collapsed_stack num_calls cycles_per_call nanoseconds_per_call total_duration percent_total_duration total_duration_exclusive percent_total_duration_exclusive
bgc::catnap::transport::epoll 6289889 4163 1749 2848948273 99 2848948273 99
ioc::network::libos::push 17610 472 187 7390653 0 7390653 0
ioc::network::libos::pop 15148 464 188 5475164 0 5475164 0
ioc::network::libos::connect 50 174388 72271 3416715 0 3416715 0
ioc::network::libos::accept 26 111477 43216 1347883 0 1347883 0
demikernel::sgaalloc 11287 114 47 1123055 0 1123055 0
demikernel::sgafree 11543 64 26 688717 0 688717 0
ioc::network::libos::close 18 22625 9068 330091 0 330091 0
ioc::network::libos::pushto 768 384 154 243930 0 243930 0

@github-actions
Copy link

libos = catnip
commit id = 4f59f3a

collapsed_stack num_calls cycles_per_call nanoseconds_per_call total_duration percent_total_duration total_duration_exclusive percent_total_duration_exclusive
bgc::inetstack::poll;inetstack::layer4::poll_once;catnip::runtime::receive 27518336 209 85 5575862288 20 5575862288 44
bgc::inetstack::poll;inetstack::layer4::poll_once 27518336 390 158 10247830418 36 4666998515 37
bgc::inetstack::poll 13759168 964 391 12701860828 44 2454030410 19
ioc::network::libos::push 16185 1095 455 17188125 0 15239040 0
bgc::inetstack::poll;inetstack::layer4::poll_once;inetstack::layer4::receive_batch 2454 3437 1363 5053845 0 5040017 0
bgc::inetstack::tcp::established::background;tcp::established::background::retransmitter 11077 307 126 4078932 0 4078058 0
bgc::inetstack::tcp::established::background 11088 1129 460 10235967 0 2764510 0
ioc::network::libos::pop 9041 401 162 2756943 0 2756943 0
bgc::inetstack::tcp::established::background;tcp::established::background::acknowledger 11088 397 164 2720263 0 2698319 0
ioc::network::libos::push;catnip::runtime::transmit 8777 291 121 2116149 0 2116149 0
ioc::network::libos::connect 42 32730 13317 1325404 0 1267188 0
demikernel::sgaalloc 6503 142 57 792978 0 792978 0
bgc::inetstack::tcp::established::background;tcp::established::background::sender 11035 318 123 672262 0 661680 0
demikernel::sgafree 8759 83 34 640857 0 640857 0
bgc::inetstack::tcp::passiveopen::background 42 24892 10327 598474 0 549456 0
ioc::network::libos::pushto 384 1911 789 547186 0 431949 0
bgc::inetstack::tcp::established::background;tcp::established::background::acknowledger;catnip::runtime::transmit 43 1540 667 136544 0 136544 0
ioc::network::libos::pushto;catnip::runtime::transmit 384 545 226 115237 0 115237 0
ioc::network::libos::connect;catnip::runtime::transmit 42 6174 2462 58216 0 58216 0
ioc::network::libos::close 49 2469 1004 55958 0 55958 0
bgc::inetstack::tcp::passiveopen::background;catnip::runtime::transmit 21 14468 6075 49018 0 49018 0
ioc::network::libos::accept 37 2206 917 48178 0 48178 0
bgc::inetstack::poll;inetstack::layer4::poll_once;inetstack::layer4::receive_batch;udp::receive 221 248 102 47817 0 47817 0
bgc::inetstack::arp::background 7 3606 1468 23505 0 23505 0
bgc::inetstack::poll;inetstack::layer4::poll_once;inetstack::layer4::receive_batch;catnip::runtime::transmit 25 618 256 12007 0 12007 0
bgc::inetstack::tcp::established::background;tcp::established::background::sender;catnip::runtime::transmit 21 583 239 10582 0 10582 0
bgc::inetstack::tcp::established::background;tcp::established::background::retransmitter;catnip::runtime::transmit 14 681 294 6120 0 6120 0
bgc::inetstack::icmp::background 1 1786 725 1952 0 1952 0

This is the latest version which works fine with Linux Catpowder;
further versions don't pass tests. Will investigate and address this if
needed in a separate PR.
@anandbonde anandbonde force-pushed the anandbonde/upgrade-rust-version branch from 4f59f3a to 8d851bc Compare April 20, 2025 17:49
@github-actions
Copy link

libos = catnap
commit id = 8d851bc

collapsed_stack num_calls cycles_per_call nanoseconds_per_call total_duration percent_total_duration total_duration_exclusive percent_total_duration_exclusive
bgc::catnap::transport::epoll 6384810 3758 1568 2858570084 99 2858570084 99
ioc::network::libos::push 17610 493 204 7417447 0 7417447 0
ioc::network::libos::pop 15164 440 182 5144668 0 5144668 0
ioc::network::libos::connect 50 176982 71734 3550260 0 3550260 0
ioc::network::libos::accept 26 116119 49042 1394566 0 1394566 0
demikernel::sgaalloc 11287 119 49 1136583 0 1136583 0
demikernel::sgafree 11543 61 25 661856 0 661856 0
ioc::network::libos::close 18 22391 9356 328827 0 328827 0
ioc::network::libos::pushto 768 372 166 260455 0 260455 0

@github-actions
Copy link

libos = catpowder
commit id = 8d851bc

collapsed_stack num_calls cycles_per_call nanoseconds_per_call total_duration percent_total_duration total_duration_exclusive percent_total_duration_exclusive
bgc::inetstack::poll;inetstack::layer4::poll_once 19846253 660 263 12593370681 46 12587595633 85
bgc::inetstack::poll 9923126 1537 613 14684267751 54 2090897071 14
ioc::network::libos::push 16262 2746 1117 49039661 0 49039661 0
bgc::inetstack::poll;inetstack::layer4::poll_once;inetstack::layer4::receive_batch 5314 2560 1000 5872930 0 5870413 0
bgc::inetstack::tcp::established::background;tcp::established::background::retransmitter 11090 384 154 5559975 0 5559975 0
ioc::network::libos::pop 9047 384 153 3435271 0 3435271 0
bgc::inetstack::tcp::established::background 11103 1716 685 12754007 0 3194427 0
bgc::inetstack::tcp::established::background;tcp::established::background::acknowledger 11103 613 250 3130460 0 3130460 0
ioc::network::libos::connect 42 39724 15960 1703064 0 1703064 0
ioc::network::libos::pushto 384 5254 2074 1689123 0 1689123 0
bgc::inetstack::tcp::passiveopen::background 42 30010 11952 1002344 0 1002344 0
demikernel::sgaalloc 6503 132 53 878816 0 878816 0
bgc::inetstack::tcp::established::background;tcp::established::background::sender 11047 896 344 869145 0 869145 0
demikernel::sgafree 8759 77 31 662745 0 662745 0
ioc::network::libos::close 46 2553 1010 63121 0 63121 0
ioc::network::libos::accept 38 2484 991 53789 0 53789 0
bgc::inetstack::poll;inetstack::layer4::poll_once;inetstack::layer4::receive_batch;udp::receive 270 219 84 49499 0 49499 0
bgc::inetstack::arp::background 8 2978 1189 17216 0 17216 0
bgc::inetstack::icmp::background 1 1786 711 1938 0 1938 0

@github-actions
Copy link

libos = catnip
commit id = 8d851bc

collapsed_stack num_calls cycles_per_call nanoseconds_per_call total_duration percent_total_duration total_duration_exclusive percent_total_duration_exclusive
bgc::inetstack::poll;inetstack::layer4::poll_once;catnip::runtime::receive 27510765 204 82 5514222693 19 5514222693 43
bgc::inetstack::poll;inetstack::layer4::poll_once 27510765 384 153 10225932551 36 4706920218 36
bgc::inetstack::poll 13755383 960 383 12900074712 45 2674142161 21
ioc::network::libos::push 16186 1095 441 17605622 0 15521913 0
bgc::inetstack::poll;inetstack::layer4::poll_once;inetstack::layer4::receive_batch 2539 2685 1060 4870821 0 4856643 0
bgc::inetstack::tcp::established::background;tcp::established::background::retransmitter 11082 316 127 4460594 0 4459260 0
bgc::inetstack::tcp::established::background;tcp::established::background::acknowledger 11093 413 170 2906884 0 2887026 0
bgc::inetstack::tcp::established::background 11093 1155 466 10800038 0 2772156 0
ioc::network::libos::pop 9041 368 148 2743944 0 2743944 0
ioc::network::libos::push;catnip::runtime::transmit 8777 300 121 2262313 0 2262313 0
ioc::network::libos::connect 42 33942 14266 1399527 0 1340843 0
demikernel::sgaalloc 6503 129 52 743276 0 743276 0
demikernel::sgafree 8759 84 34 667123 0 667123 0
bgc::inetstack::tcp::established::background;tcp::established::background::sender 11040 310 121 660404 0 650408 0
bgc::inetstack::tcp::passiveopen::background 42 25312 10083 583979 0 534883 0
ioc::network::libos::pushto 384 1965 785 559834 0 435835 0
ioc::network::libos::pushto;catnip::runtime::transmit 384 652 259 123999 0 123999 0
bgc::inetstack::tcp::established::background;tcp::established::background::acknowledger;catnip::runtime::transmit 41 1917 860 123559 0 123559 0
ioc::network::libos::connect;catnip::runtime::transmit 42 6522 2582 58683 0 58683 0
ioc::network::libos::close 49 2578 1032 57581 0 57581 0
bgc::inetstack::tcp::passiveopen::background;catnip::runtime::transmit 21 14433 5806 49096 0 49096 0
ioc::network::libos::accept 37 2165 863 45154 0 45154 0
bgc::inetstack::poll;inetstack::layer4::poll_once;inetstack::layer4::receive_batch;udp::receive 216 233 95 44941 0 44941 0
bgc::inetstack::arp::background 7 3132 1253 23133 0 23133 0
bgc::inetstack::poll;inetstack::layer4::poll_once;inetstack::layer4::receive_batch;catnip::runtime::transmit 26 694 278 12529 0 12529 0
bgc::inetstack::tcp::established::background;tcp::established::background::sender;catnip::runtime::transmit 21 563 226 9996 0 9996 0
bgc::inetstack::tcp::established::background;tcp::established::background::retransmitter;catnip::runtime::transmit 18 739 324 7469 0 7469 0
bgc::inetstack::icmp::background 1 1796 719 1939 0 1939 0

@iyzhang iyzhang merged commit e6d0a67 into dev Apr 22, 2025
14 checks passed
@iyzhang iyzhang deleted the anandbonde/upgrade-rust-version branch April 22, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants