Add "Experimental Features" in settings #1707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbonaby
reviewed
Oct 17, 2023
settings/DevHome.Settings/ViewModels/ExperimentalFeaturesViewModel.cs
Outdated
Show resolved
Hide resolved
krschau
reviewed
Oct 17, 2023
Co-authored-by: Kristen Schau <47155823+krschau@users.noreply.github.com>
Co-authored-by: Kristen Schau <47155823+krschau@users.noreply.github.com>
Co-authored-by: Kristen Schau <47155823+krschau@users.noreply.github.com>
Co-authored-by: Kristen Schau <47155823+krschau@users.noreply.github.com>
krschau
reviewed
Oct 19, 2023
|
Strings LGTM :) |
…/microsoft/devhome into user/asklar/experimentalFeatures
bbonaby
approved these changes
Oct 19, 2023
There was a problem hiding this comment.
This looks good to me. @EricJohnson327 and @krschau are we all good to approve?
EricJohnson327
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
Adds a new setting for controlling the state of Experimental Features; this will allow us to ship MVPs and get feedback sooner.
References and relevant issues
Needed for #1049
Detailed description of the pull request / Additional comments
experimentsarray in navconfig.json.experimentId; the tool will only be available if the experiment is enabled.Validation steps performed
Locally validated
PR checklist