Increasing the open pane length for the main navigation pane. #1782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhoehna
requested review from
manodasanW,
florelis,
vineeththomasalex,
dkbennett,
krschau,
EricJohnson327,
AmelBawa-msft,
bbonaby,
ssparach and
a team
krschau
approved these changes
Nov 1, 2023
AmelBawa-msft
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
The open pane length defaults to 320. 320 is a tad too short when the text is scaled to 200%. Added a value to make sure the length is long enough for text scaling to 225%
This is a solution for English. More work needs to be done to adapt to other languages or longer strings.
#1806 to track this.
References and relevant issues
http://task.ms/46724819
Detailed description of the pull request / Additional comments
Validation steps performed
Changed text scaling before opening DevHome.
PR checklist
Pictures
Originals
100% Text scaling
200% scaling
Modified
100%
200%
225%
