Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow keyboard access to entire NavigationView by moving it down #1804

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

krschau
Copy link
Collaborator

@krschau krschau commented Nov 1, 2023

Summary of the pull request

The NavigationView was badly interacting with the custom title bar, and it was impossible to tab to the top option ("Dashboard"). We solve the problem by moving the whole NavigationView down, under the title bar.

image

References and relevant issues

https://task.ms/46742514

Detailed description of the pull request / Additional comments

Validation steps performed

PR checklist

@krschau krschau changed the title move nav view down Allow keyboard access to entire NavigationView by moving it down Nov 1, 2023
@EricJohnson327 EricJohnson327 added the Needs-Second Pull request that needs another approval label Nov 1, 2023
@krschau krschau removed the Needs-Second Pull request that needs another approval label Nov 1, 2023
@krschau krschau merged commit 17f4dd1 into main Nov 1, 2023
4 checks passed
@krschau krschau deleted the user/krschau/acc-nav branch November 1, 2023 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants