Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix accessibility issues in What's New page #1808

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

krschau
Copy link
Collaborator

@krschau krschau commented Nov 1, 2023

Summary of the pull request

Fixes four accessibility problem areas and one style bug:

  • With text scaled up or a narrow window, the small card text (above the buttons) was getting cut off. Adding a ScrollViewer makes it readable. (I tried making the card longer and had trouble)
  • With text scaled up or a narrow window, the big card text was getting cut off. Change the Width to MaxWidth=400 so that the text can wrap appropriately with the container.
  • Text gets cut off in the Welcome to Dev Home Page  #1512 With text scaled up or a narrow window, the text at the top of the page was getting cut off. Changing from a Grid with fixed sizes to a StackPanel with a min size allows the area to size up with the text.
    • Also deleted junk "Text" from WhatsNewPage_Description
  • Narrator reads "Link" for every FRE page card, even when there is no visible link #1722 Most cards do not have content in their HyperlinkButtons, but those HyperlinkButtons were still tab stops that could take focus. Change to only make them a tab stop if there is content.
  • (Not accessibility) "Get started" button at the top of the page was cut off when the window is at its narrowest. Making the button slightly narrow prevents it from being cut off, but is still plenty wide enough to show text.

References and relevant issues

http://task.ms/46725464
#1722
#1755
#1512

Detailed description of the pull request / Additional comments

Validation steps performed

PR checklist

@krschau krschau added the Needs-Second Pull request that needs another approval label Nov 1, 2023
@krschau krschau merged commit bd6775d into main Nov 2, 2023
4 checks passed
@krschau krschau removed the Needs-Second Pull request that needs another approval label Nov 2, 2023
@krschau krschau deleted the user/krschau/acc-whatsnew-card branch November 7, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants