Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give buttons accessible names #1962

Merged
merged 3 commits into from
Nov 29, 2023
Merged

Give buttons accessible names #1962

merged 3 commits into from
Nov 29, 2023

Conversation

krschau
Copy link
Collaborator

@krschau krschau commented Nov 27, 2023

Summary of the pull request

Gives accessible names, that can be read by Narrator, to three buttons:

  • "Pin" button in the Add Widget dialog
  • "More options" button in the Extensions list
  • "Close" buttons, used in the Add Widget dialog and other places.

References and relevant issues

Detailed description of the pull request / Additional comments

Validation steps performed

PR checklist

@AmelBawa-msft AmelBawa-msft added the Needs-Second Pull request that needs another approval label Nov 27, 2023
@krschau krschau merged commit a5b82d3 into main Nov 29, 2023
4 checks passed
@krschau krschau removed the Needs-Second Pull request that needs another approval label Nov 29, 2023
@krschau krschau deleted the user/krschau/acc-button-names branch November 30, 2023 20:11
@krschau krschau added this to the Dev Home v0.8 milestone Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some buttons are missing accessible names
3 participants