Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev drive craftmanship issues #1969

Merged
merged 10 commits into from
Nov 30, 2023
Merged

Conversation

dhoehna
Copy link
Contributor

@dhoehna dhoehna commented Nov 28, 2023

Summary of the pull request

List of changes

  1. DevDrive out of space error uses the whole width of the dialog box.
  2. The space between DevDrive size and size units is reduced. Closer to the mocks.
  3. DevDrive removal warning is left-justified
  4. Scroll bar hugs the right side of the DevDrive customization modal.
  5. Reset errors when the size unit is changed to allow the save button to be clicked.

Also, removed some hard coded values in XAML.

References and relevant issues

Detailed description of the pull request / Additional comments

Validation steps performed

Manual validation with Branden. Added a DevDrive and repos. DevDrive was created and the repos ere cloned.

PR checklist

  • Closes #xxx
  • Tests added/passed
  • Documentation updated

Pictures!
Out of space error
OutOfSpaceErrorUsingWholeWidth

Size and unit combobox spacing
SizeAndUnitReducesGap

Scroll bar on the right
ScrollBarOnTheRightEdge

Stretched out Dev Drive window!
image

Dev Drive removal error left justified
DevDriveRemovalWarning

Repo config list view.
RepoConfigViewNotHardCodingHeight

Repo review list view
RepoConfigReviewWithNoHardCodedHeight

Movie!
Dev drive changing size unit
DevDriveChangingSizeUnits

Copy link
Contributor

@bbonaby bbonaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously the right margin of the scrollviewer was 10 and the right margin for the stack panel that contains all the content was 10. Together that made a margin of 20. Now that we removed the scrollviewer margins I forgot to ask you to add 10 to the stackpanel.
So i updated it with the last commit. From 10 to 20 to compensate for the right margin value that was removed from the scrollviewer.

Thanks Darren!

@dhoehna dhoehna added the Needs-Second Pull request that needs another approval label Nov 30, 2023
@dhoehna dhoehna merged commit 928ea4e into main Nov 30, 2023
4 checks passed
@krschau krschau removed the Needs-Second Pull request that needs another approval label Dec 6, 2023
@krschau krschau added this to the Dev Home v0.8 milestone Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants