-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev drive craftmanship issues #1969
Conversation
tools/SetupFlow/DevHome.SetupFlow/ViewModels/DevDriveViewModel.cs
Outdated
Show resolved
Hide resolved
tools/SetupFlow/DevHome.SetupFlow/ViewModels/DevDriveViewModel.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Branden Bonaby <105318831+bbonaby@users.noreply.github.com>
Co-authored-by: Branden Bonaby <105318831+bbonaby@users.noreply.github.com>
…hub.com/microsoft/devhome into user/dhoehna/DevDriveCraftmanshipIssues
…e scroller viewer. This is because of the removal of the margins for scrollviewer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previously the right margin of the scrollviewer was 10 and the right margin for the stack panel that contains all the content was 10. Together that made a margin of 20. Now that we removed the scrollviewer margins I forgot to ask you to add 10 to the stackpanel.
So i updated it with the last commit. From 10 to 20 to compensate for the right margin value that was removed from the scrollviewer.
Thanks Darren!
Summary of the pull request
List of changes
Also, removed some hard coded values in XAML.
References and relevant issues
Detailed description of the pull request / Additional comments
Validation steps performed
Manual validation with Branden. Added a DevDrive and repos. DevDrive was created and the repos ere cloned.
PR checklist
Pictures!
Out of space error
Size and unit combobox spacing
Scroll bar on the right
Stretched out Dev Drive window!
Dev Drive removal error left justified
Repo config list view.
Repo review list view
Movie!
Dev drive changing size unit