Save RenderedAdaptiveCard to Panel #2035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vineeththomasalex
requested review from
guimafelipe,
krschau,
jamespik,
EricJohnson327 and
ssparach
krschau
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
"Missing button action on click" problem which occurs sporadically might be due to the parent object going out of scope and getting GC'd. We can save the RenderedAdaptiveCard object to avoid this.
References and relevant issues
microsoft/devhomegithubextension#108
Detailed description of the pull request / Additional comments
Validation steps performed
Manually ran the button action several times.
PR checklist