Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "Extensions" page from Settings #2301

Merged
merged 8 commits into from
Feb 26, 2024
Merged

Conversation

krschau
Copy link
Collaborator

@krschau krschau commented Feb 22, 2024

Summary of the pull request

Remove the "Extensions" page from settings, in favor of navigation to extension settings through the Extensions page in the left nav.

References and relevant issues

#2212

Detailed description of the pull request / Additional comments

  • Moved ExtensionSettings (page and viewmodel) to the Extensions project, since now that's the only place it is accessed by.
  • Separate SettingViewModel into its own file separate from SettingsViewModel
  • Remove logic to create a different breadcrumb bar depending on where we navigated from
  • Remove special handling in page navigation
  • Remove telemetry event sending which page was navigated from, since there's only one option now

Validation steps performed

Validated locally.

PR checklist

@krschau krschau added the Needs-Second Pull request that needs another approval label Feb 23, 2024
@krschau krschau merged commit c0386ee into main Feb 26, 2024
4 checks passed
@krschau krschau removed the Needs-Second Pull request that needs another approval label Feb 26, 2024
@krschau krschau deleted the user/krschau/extensions-settings branch March 5, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove "Extensions" from Settings Page
3 participants