-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update theme of Add Widget dialog when system theme changes #2407
Conversation
tools/Dashboard/DevHome.Dashboard/ViewModels/AddWidgetViewModel.cs
Outdated
Show resolved
Hide resolved
{ | ||
foreach (var widgetItem in providerItem.MenuItems.Cast<NavigationViewItem>()) | ||
{ | ||
var widgetDefinition = widgetItem.Tag as WidgetDefinition; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to try catch widget definition usage, or we don't expect RPC errors here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically yes, I think we should, but I think the only way to do this without making the whole dashboard a mess of try/catches is to wrap the widget objects in a model so we don't have to be querying the real objects the entire time (which I do plan to do at some point).
tools/Dashboard/DevHome.Dashboard/Views/AddWidgetDialog.xaml.cs
Outdated
Show resolved
Hide resolved
tools/Dashboard/DevHome.Dashboard/Views/AddWidgetDialog.xaml.cs
Outdated
Show resolved
Hide resolved
…ther than passing it in
7147f08
to
09ecc5e
Compare
Summary of the pull request
If the user updated the system theme while the Add Widget dialog was open, the dialog would not update. This change fixes the problem by:
This change has the nice side-effect of decoupling the AddWidgetView and the DashboardView, by requiring the DashboardView to pass in the dispatcherQueue or ActualTheme anymore. It will also make it easier to move more logic from the AddWidget View to ViewModel in the future if we want to.
References and relevant issues
Detailed description of the pull request / Additional comments
Validation steps performed
PR checklist