-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial support for generating a configuration file from machine configuration #2466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AmelBawa-msft
requested review from
bbonaby,
krschau,
manodasanW,
dhoehna,
vineeththomasalex and
EricJohnson327
March 28, 2024 19:01
AmelBawa-msft
commented
Mar 28, 2024
tools/SetupFlow/DevHome.SetupFlow/ViewModels/ReviewViewModel.cs
Outdated
Show resolved
Hide resolved
dhoehna
reviewed
Mar 29, 2024
dhoehna
reviewed
Mar 29, 2024
dhoehna
reviewed
Mar 29, 2024
tools/SetupFlow/DevHome.SetupFlow/ViewModels/ReviewViewModel.cs
Outdated
Show resolved
Hide resolved
dhoehna
reviewed
Mar 29, 2024
dhoehna
approved these changes
Mar 29, 2024
bbonaby
reviewed
Apr 3, 2024
bbonaby
approved these changes
Apr 4, 2024
This was referenced May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
Initial support for generating a configuration file from the machine configuration flow.
Limitation in this PR:
References and relevant issues
Detailed description of the pull request / Additional comments
Validation steps performed
Selecting an already installed app
Review page allows downloading the generated configuration file
Generated file:
PR checklist