Add Action.ChooseFile for adaptive cards #2477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@krschau - this is the starting point we can work from, still got some refactoring, UI clean up etc. to finish! |
krschau
reviewed
Mar 27, 2024
tools/Dashboard/DevHome.Dashboard/ViewModels/WidgetViewModel.cs
Outdated
Show resolved
Hide resolved
joadoumie
commented
Mar 28, 2024
joadoumie
commented
Mar 28, 2024
3 tasks
krschau
force-pushed
the
user/joadoumie/file-picker
branch
3 times, most recently
from
1f64109 to
b383d43
Compare
krschau
force-pushed
the
user/joadoumie/file-picker
branch
from
b383d43 to
d86f2af
Compare
…renderer in the dev home widget AC Host... Includes changes to the SSH Keychain core widget to include the file picker action
krschau
force-pushed
the
user/joadoumie/file-picker
branch
from
18d0b93 to
a2c75d3
Compare
krschau
changed the title
krschau
requested review from
guimafelipe,
dkbennett,
EricJohnson327,
AmelBawa-msft and
bbonaby
guimafelipe
approved these changes
Jun 5, 2024
|
|
||
| // Parse the JSON properties of the action. | ||
| // The Verb ChooseFile is not meant to be localized. | ||
| Verb = inputJson.GetNamedString("verb", "ChooseFile"), |
There was a problem hiding this comment.
The verb in this case is always intended to be "ChooseFile"? Should the user be able to use a different string for this verb?
There was a problem hiding this comment.
This should get the verb specified in the card, and if one is not specified, use the default of "ChooseFile".
EricJohnson327
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
The Action.ChooseFile adaptive card element allows a card author to launch a File Picker from Dev Home and obtain the chosen file. If no file is chosen, the "FilePath" field will be null. The author may use the action as an "inlineAction" on a Text input. The SSH Keychain widget uses the action this way.
This action is experimental while it goes through API review.
References and relevant issues
Detailed description of the pull request / Additional comments
Validation steps performed
PR checklist