-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial environments creation flow to the machine configuration tool #2493
Merged
bbonaby
merged 28 commits into
main
from
user/bbonaby/add-initial-creation-flow-in-setup-flow
Apr 5, 2024
Merged
Add initial environments creation flow to the machine configuration tool #2493
bbonaby
merged 28 commits into
main
from
user/bbonaby/add-initial-creation-flow-in-setup-flow
Apr 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aby/add-hyper-v-code-for-creation-adaptive-cards
…ds' into user/bbonaby/add-initial-creation-flow-in-setup-flow
…p after moving to a different page
tools/SetupFlow/DevHome.SetupFlow/Models/Environments/CreationAdaptiveCardSessionEndedData.cs
Show resolved
Hide resolved
...s/SetupFlow/DevHome.SetupFlow/ViewModels/Environments/EnvironmentCreationOptionsViewModel.cs
Show resolved
Hide resolved
...s/SetupFlow/DevHome.SetupFlow/ViewModels/Environments/EnvironmentCreationOptionsViewModel.cs
Outdated
Show resolved
Hide resolved
tools/SetupFlow/DevHome.SetupFlow/ViewModels/Environments/SelectEnvironmentProviderViewModel.cs
Outdated
Show resolved
Hide resolved
tools/SetupFlow/DevHome.SetupFlow/ViewModels/Environments/SelectEnvironmentProviderViewModel.cs
Outdated
Show resolved
Hide resolved
tools/SetupFlow/DevHome.SetupFlow/ViewModels/Environments/SelectEnvironmentProviderViewModel.cs
Outdated
Show resolved
Hide resolved
…om holding onto items view control internally
…aby/add-hyper-v-code-for-creation-adaptive-cards
…ds' into user/bbonaby/add-initial-creation-flow-in-setup-flow
dhoehna
reviewed
Apr 3, 2024
/// The view in this case would not want to using Binding to bind to the adaptive card, but instead request it and then manually | ||
/// add it to its UI. This prevents xaml binding crashes with "Element is already the child of another element" exceptions. | ||
/// </remarks> | ||
public sealed class CreationOptionsReviewPageDataRequestMessage : RequestMessage<RenderedAdaptiveCard> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this class blank on purpose?
AmelBawa-msft
approved these changes
Apr 3, 2024
tools/SetupFlow/DevHome.SetupFlow/ViewModels/Environments/SelectEnvironmentProviderViewModel.cs
Outdated
Show resolved
Hide resolved
tools/SetupFlow/DevHome.SetupFlow/ViewModels/Environments/SelectEnvironmentProviderViewModel.cs
Outdated
Show resolved
Hide resolved
tools/SetupFlow/DevHome.SetupFlow/ViewModels/Environments/SelectEnvironmentProviderViewModel.cs
Outdated
Show resolved
Hide resolved
sshilov7
reviewed
Apr 5, 2024
3 tasks
sshilov7
reviewed
Apr 5, 2024
...s/SetupFlow/DevHome.SetupFlow/ViewModels/Environments/EnvironmentCreationOptionsViewModel.cs
Show resolved
Hide resolved
sshilov7
approved these changes
Apr 5, 2024
bbonaby
changed the base branch from
user/bbonaby/add-hyper-v-code-for-creation-adaptive-cards
to
main
April 5, 2024 20:34
bbonaby
changed the base branch from
main
to
user/bbonaby/add-hyper-v-code-for-creation-adaptive-cards
April 5, 2024 20:35
bbonaby
changed the base branch from
user/bbonaby/add-hyper-v-code-for-creation-adaptive-cards
to
main
April 5, 2024 22:21
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
This is PR 3 of 4 to add the ability to create environments from within Dev Home. I currently have 2 other PRs:
That will go into a feature branch before going into main. Please look at those for context. This PR adds the Create Environments flow to the machine configuration tool. It utilizes adaptive cards that are retrieved from a Dev Home extension to display the provider specific UI to the user. There are 3 pages:
CreateEnvironmentFlowUpToReviewPage.mp4
We use weak references to send messages between the view model and the views to allow the views to be disposed once they are unloaded. The DevHome Settings card adaptive card control (added in PR #1 above) is used by the Hyper-V extension, to display the list of images that can be used to create a VM just like Hyper-V quick create window.
.
References and relevant issues
Detailed description of the pull request / Additional comments
Note: The use of the ExtensionAdaptiveCardPanel for this kind of wizard flow causes random xaml crashes due to an exception where xaml sees a control being parented to multiple other controls. So it was not used for this feature
Validation steps performed
PR checklist