Adding AutomationProperties.Name to Banner #2510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
This adds AutomationProperties.Name to the baseline Banner view, so it can be narrated by the narrator.
References and relevant issues
https://dev.azure.com/microsoft/OS/_workitems/edit/49356757
Detailed description of the pull request / Additional comments
When a user is with scan mode off in the narrator, they got to the button inside de banner without listening to the title of it. This changes makes the narrator actually tell the title of the banner instead of "Dashboard Banner" or "Machine Configuration Banner".
Validation steps performed
PR checklist