Fix DevSetupAgent logging and some other fixes.

[sshilov7]

Summary of the pull request

DevSetupAgent and DevSetupEngine were crashing on start after previous (#2474) change to logging setup.
This change

• Fixes DevSetupAgent and DevSetupEngine logging to output loggs into
  %localappdata%\Temp\DevSetupEngine\Logs\HyperV directory (like C:\Users\LocalAdmin\AppData\Local\Temp\DevSetupEngine\Logs\HyperV for DevSetupgent)
• Adds COM access permission to DevSetupAgent to allow calls from LocalSystem and Interactive Users only.
• Move Hyper-V DevSetupAgent PS script into a separate file (DevSetupAgent.ps1)
• Move HResultException.cs to HyperVExtension.HostGuestCommunication library to use on DevSetupAgent side
• Small fixes to error message in Host-Guest communication

Validation steps performed

Tested DevSetupAgent setup, start and configuration workflow on a Hyper-V VM.

PR checklist

• Closes #xxx
• Tests added/passed
• Documentation updated

[krschau]

I think we should keep all the Logs under the Logs folder, so instead of
%localappdata%\Temp\DevSetupEngine\Logs\HyperV
it would be
%localappdata%\TempState\Logs\DevSetupEngine\HyperV

From my understanding of how future enhancements to let FeedbackHub collect logs would work, using this new place would be a headache.

[krschau]

Log location comment. See

devhome/extensions/CoreWidgetProvider/Program.cs

Line 17 in 13fe40e

Environment.SetEnvironmentVariable("DEVHOME_LOGS_ROOT", Path.Join(Helpers.Logging.LogFolderRoot, "CoreWidgets"));

for suggestion on how to get the location.

[sshilov7]

@krschau , I don't understand what you are asking for referring to devhome/extensions/CoreWidgetProvider/Program.cs. Please clarify.

As for the actual location: %localappdata%\TempState normally does not exist and is not documented. Currently, Dev Home logs go under %localappdata%\Packages<PackageFamilyName>\TempState\Logs. Code changed in this PR is not part of Dev Home packaged app and doesn't have package identity and cannot write logs under that location. Furthermore, DevSetupAgent runs under LocalSystem account and cannot write logs under some user's account where Dev Home may exist.

[huzaifa-d]

Suggestion: Add a brief message describing the error and where it failed.

[krschau]

@krschau , I don't understand what you are asking for referring to devhome/extensions/CoreWidgetProvider/Program.cs. Please clarify.

As for the actual location: %localappdata%\TempState normally does not exist and is not documented. Currently, Dev Home logs go under %localappdata%\Packages\TempState\Logs. Code changed in this PR is not part of Dev Home packaged app and doesn't have package identity and cannot write logs under that location. Furthermore, DevSetupAgent runs under LocalSystem account and cannot write logs under some user's account where Dev Home may exist.

Sorry, I assumed this was part of the extension and could write to the Dev Home logs.

Misunderstood logging