Wrap WidgetDefinition objects in a COM-safe wrapper #2622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krschau
requested review from
dhoehna,
guimafelipe,
vineeththomasalex,
dkbennett,
EricJohnson327 and
AmelBawa-msft
EricJohnson327
approved these changes
Apr 12, 2024
krschau
force-pushed
the
user/krschau/comsafewidgetdefinition
branch
from
fbde8aa
to
13a5c89
Compare
dhoehna
reviewed
Apr 12, 2024
tools/Dashboard/DevHome.Dashboard/ComSafeWidgetObjects/ComSafeWidgetDefinition.cs
Outdated
Show resolved
Hide resolved
dhoehna
approved these changes
Apr 12, 2024
krschau
force-pushed
the
user/krschau/comsafewidget
branch
2 times, most recently
from
b435f8f
to
cb44ee5
Compare
krschau
force-pushed
the
user/krschau/comsafewidgetdefinition
branch
2 times, most recently
from
bb2d779
to
d0c8867
Compare
krschau
force-pushed
the
user/krschau/comsafewidgetdefinition
branch
from
d0c8867
to
e3054c3
Compare
tools/Dashboard/DevHome.Dashboard/ComSafeWidgetObjects/ComSafeHelpers.cs
Outdated
Show resolved
Hide resolved
tools/Dashboard/DevHome.Dashboard/ComSafeWidgetObjects/ComSafeWidgetDefinition.cs
Outdated
Show resolved
Hide resolved
tools/Dashboard/DevHome.Dashboard/ComSafeWidgetObjects/ComSafeWidgetDefinition.cs
Outdated
Show resolved
Hide resolved
tools/Dashboard/DevHome.Dashboard/ComSafeWidgetObjects/ComSafeWidgetDefinition.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
Since WidgetDefinition objects are out of process, they can disappear out from under us throwing COMExceptions and crashing Dev Home. Wrap them in a new ComSafeWidgetDefinition wrapper, which catches these exceptions and gets a new, valid object when the old one goes away.
This PR is currently targeted into the branch for #2620, will retarget after that goes in.
References and relevant issues
Detailed description of the pull request / Additional comments
Validation steps performed
PR checklist