-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some PowerToys utilities in DevHome #2795
Conversation
tools/Utilities/HostsUtility/Views/HostsFileEditorSettingsWindow.xaml.cs
Outdated
Show resolved
Hide resolved
tools/Utilities/RegPreviewUtility/appsettings_registrypreview.json
Outdated
Show resolved
Hide resolved
tools/Utilities/HostsUtility/Views/HostsFileEditorSettingsWindow.xaml
Outdated
Show resolved
Hide resolved
tools/Utilities/HostsUtility/Views/HostsFileEditorSettingsWindow.xaml
Outdated
Show resolved
Hide resolved
tools/Utilities/RegPreviewUtility/DevHome.RegistryPreview.csproj
Outdated
Show resolved
Hide resolved
tools/Utilities/EnvVariablesUtility/EnvironmentVariablesApp.xaml.cs
Outdated
Show resolved
Hide resolved
tools/Utilities/EnvVariablesUtility/EnvironmentVariablesAppMainWindow.xaml.cs
Outdated
Show resolved
Hide resolved
tools/Utilities/EnvVariablesUtility/EnvironmentVariablesAppMainWindow.xaml.cs
Show resolved
Hide resolved
tools/Utilities/HostsUtility/ViewModels/HostsFileEditorSettingsViewModel.cs
Outdated
Show resolved
Hide resolved
tools/Utilities/RegPreviewUtility/RegistryPreviewMainWindow.xaml.cs
Outdated
Show resolved
Hide resolved
347c479
to
f46ffb3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Things look good from a Telemetry perspective. Also had offline conversations about it so I won't dirty up this PR with already-provided feedback. The other stuff looks OK but I do have concerns about the adding of apps to Dev Home. @EricJohnson327 should definitely review this PR.
tools/Utilities/EnvVariablesUtility/EnvironmentVariablesAppMainWindow.xaml.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Un-approving because the versioning questions and apps being added to DevHome is a significant concern of mine.
Un-approving because the versioning questions and apps being added to DevHome is a significant concern of mine.
tools/Utilities/EnvVariablesUtility/EnvironmentVariablesApp.xaml
Outdated
Show resolved
Hide resolved
tools/Utilities/EnvVariablesUtility/EnvironmentVariablesAppMainWindow.xaml.cs
Show resolved
Hide resolved
tools/Utilities/EnvVariablesUtility/TelemetryEvents/EnvironmentVariablesProfileEnabledEvent.cs
Outdated
Show resolved
Hide resolved
tools/Utilities/HostsUtility/Assets/HostsFileEditor/LargeTile.scale-100.png
Outdated
Show resolved
Hide resolved
@dabhattimsft Please open an issue for this if one does not already exist. |
tools/Utilities/EnvVariablesUtility/EnvironmentVariablesAppMainWindow.xaml.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a fan of the new dependency or apps but I have no concerns with the code changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add "Utilities" to the list of tools in https://github.com/microsoft/devhome/blob/main/docs/architecture.md? It doesn't have to link to anything.
Summary of the pull request
This PR brings Hosts File Editor, Registry Preview and Environment Variables editor to DevHome
References and relevant issues
Detailed description of the pull request / Additional comments
This PR adds 3 applications to devhome package. Each of these apps consume nuget produced by PowerToys. This nuget contains the essential functionality and UX. On the DevHome side, the code handles Application, MainWindow, Logging and Telemetry.
Validation steps performed
Manually validated launching these utilities from DevHome, launching these as admin from DevHome, launching them from start menu as user and as admin.
PR checklist