Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some PowerToys utilities in DevHome #2795

Merged
merged 12 commits into from
May 7, 2024

Conversation

dabhattimsft
Copy link
Contributor

@dabhattimsft dabhattimsft commented May 2, 2024

Summary of the pull request

This PR brings Hosts File Editor, Registry Preview and Environment Variables editor to DevHome

References and relevant issues

Detailed description of the pull request / Additional comments

This PR adds 3 applications to devhome package. Each of these apps consume nuget produced by PowerToys. This nuget contains the essential functionality and UX. On the DevHome side, the code handles Application, MainWindow, Logging and Telemetry.

Validation steps performed

Manually validated launching these utilities from DevHome, launching these as admin from DevHome, launching them from start menu as user and as admin.

PR checklist

Packaging/Package.appxmanifest Outdated Show resolved Hide resolved
src/DevHome.csproj Show resolved Hide resolved
tools/Utilities/src/Views/UtilityView.xaml Outdated Show resolved Hide resolved
@dabhattimsft dabhattimsft force-pushed the user/dabhatti/powerToysInDevHome branch from 347c479 to f46ffb3 Compare May 3, 2024 18:45
@dabhattimsft dabhattimsft marked this pull request as ready for review May 5, 2024 21:57
dkbennett
dkbennett previously approved these changes May 6, 2024
Copy link
Member

@dkbennett dkbennett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things look good from a Telemetry perspective. Also had offline conversations about it so I won't dirty up this PR with already-provided feedback. The other stuff looks OK but I do have concerns about the adding of apps to Dev Home. @EricJohnson327 should definitely review this PR.

Copy link
Member

@dkbennett dkbennett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Un-approving because the versioning questions and apps being added to DevHome is a significant concern of mine.

@dkbennett dkbennett dismissed their stale review May 6, 2024 18:40

Un-approving because the versioning questions and apps being added to DevHome is a significant concern of mine.

src/DevHome.csproj Outdated Show resolved Hide resolved
@krschau
Copy link
Collaborator

krschau commented May 6, 2024

@dabhattimsft Please open an issue for this if one does not already exist.

@dabhattimsft dabhattimsft requested a review from subhasan May 6, 2024 23:55
Copy link
Member

@dkbennett dkbennett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a fan of the new dependency or apps but I have no concerns with the code changes.

Copy link
Collaborator

@krschau krschau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add "Utilities" to the list of tools in https://github.com/microsoft/devhome/blob/main/docs/architecture.md? It doesn't have to link to anything.

@dabhattimsft dabhattimsft merged commit 96fe829 into main May 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add some PowerToys utilities
6 participants