-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bringing Project Ironsides into Dev Home #2887
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaholme
requested review from
nieubank,
aeloros,
andreww-msft,
dabhattimsft,
krschau,
timkur,
EricJohnson327 and
zadesai
May 10, 2024 22:46
…o fix version mismatch warning. The following warning is due to referencing the version of System.Drawing.Common another component includes. This change updates the version to 8.0.0.0 and gets rid of the warning. Verified: 1. Build no longer prints warning. 2. PI launches with no issues. warning MSB3277: Found conflicts between different versions of "System.Drawing.Common" that could not be resolved. warning MSB3277: There was a conflict between "System.Drawing.Common, Version=6.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51" and "System.Drawing.Common, Version=8.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51". warning MSB3277: "System.Drawing.Common, Version=6.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51" was chosen because it was primary and "System.Drawing.Common, Version=8.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51" was not. warning MSB3277: References which depend on "System.Drawing.Common, Version=6.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51" [E:\repos\DevHome\packages\system.drawing.common\6.0.0\lib\net6.0\System.Drawing.Common.dll]. warning MSB3277: E:\repos\DevHome\packages\system.drawing.common\6.0.0\lib\net6.0\System.Drawing.Common.dll warning MSB3277: Project file item includes which caused reference "E:\repos\DevHome\packages\system.drawing.common\6.0.0\lib\net6.0\System.Drawing.Common.dll". warning MSB3277: E:\repos\DevHome\packages\system.drawing.common\6.0.0\lib\net6.0\System.Drawing.Common.dll warning MSB3277: References which depend on or have been unified to "System.Drawing.Common, Version=8.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51" []. warning MSB3277: E:\repos\DevHome\packages\system.windows.extensions\8.0.0\lib\net8.0\System.Windows.Extensions.dll warning MSB3277: Project file item includes which caused reference "E:\repos\DevHome\packages\system.windows.extensions\8.0.0\lib\net8.0\System.Windows.Extensions.dll". warning MSB3277: E:\repos\DevHome\packages\system.windows.extensions\8.0.0\lib\net8.0\System.Windows.Extensions.dll warning MSB3277: E:\repos\DevHome\packages\system.security.permissions\8.0.0\lib\net8.0\System.Security.Permissions.dll warning MSB3277: E:\repos\DevHome\packages\system.directoryservices\8.0.0\lib\net8.0\System.DirectoryServices.dll
dhoehna
reviewed
May 13, 2024
dhoehna
approved these changes
May 13, 2024
nieubank
reviewed
May 13, 2024
krschau
reviewed
May 14, 2024
krschau
reviewed
May 14, 2024
krschau
reviewed
May 14, 2024
vineeththomasalex
approved these changes
May 14, 2024
krschau
reviewed
May 14, 2024
nieubank
reviewed
May 14, 2024
nieubank
reviewed
May 14, 2024
nieubank
reviewed
May 14, 2024
nieubank
reviewed
May 14, 2024
nieubank
reviewed
May 14, 2024
nieubank
reviewed
May 14, 2024
nieubank
reviewed
May 14, 2024
nieubank
reviewed
May 14, 2024
nieubank
reviewed
May 14, 2024
Co-authored-by: Kristen Schau <47155823+krschau@users.noreply.github.com>
zadesai
reviewed
May 15, 2024
nieubank
approved these changes
May 15, 2024
EricJohnson327
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
This PR adds the Project Ironsides experimental feature to Dev Home.
References and relevant issues
#2796
Detailed description of the pull request / Additional comments
As described in #2796 this brings in the initial scaffolding for Dev Home PI(Project Ironsides) a new feature to allow deeper investigation into applications.
Project Ironsides when enabled in Dev Home experimental settings shows up in the Utilites section of Dev Home.
Validation steps performed
Full build has been kicked off internally to validate the changes.
PR checklist