-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data storage (i.e. extension and registered root path) for version control extensions inside Dev Home #2984
Data storage (i.e. extension and registered root path) for version control extensions inside Dev Home #2984
Conversation
tools/Customization/DevHome.Customization/Views/FileExplorerPage.xaml
Outdated
Show resolved
Hide resolved
tools/Customization/DevHome.Customization/Views/FileExplorerPage.xaml
Outdated
Show resolved
Hide resolved
tools/Customization/DevHome.Customization/Views/FileExplorerPage.xaml
Outdated
Show resolved
Hide resolved
tools/Customization/DevHome.Customization/Views/FileExplorerPage.xaml
Outdated
Show resolved
Hide resolved
tools/Customization/DevHome.Customization/Views/FileExplorerPage.xaml.cs
Outdated
Show resolved
Hide resolved
tools/Customization/DevHome.Customization/Views/FileExplorerPage.xaml.cs
Outdated
Show resolved
Hide resolved
tools/Customization/DevHome.Customization/Views/FileExplorerPage.xaml.cs
Outdated
Show resolved
Hide resolved
if (!Path.IsPathFullyQualified(rootPath)) | ||
{ | ||
// Error: Path is not fully qualified or maybe a UNC path. | ||
RootPathErrorBar.IsOpen = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT: Change the error message based on what is being checked. Give the user the exact reason why the path isn't valid.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT: Change the error message based on what is being checked. Give the user the exact reason why the path isn't valid.
+1 to this. We may even consider having some different error/exception types for path checking.
Once interesting example is that repositories mounted on WSL look sorta like UNC paths, but we should try to detect that case separate from UNC paths. Also with WSL repos, their file ownership looks off from Windows' point of view, so Git will raise specific errors about those cases. Rather than outright failing, we should offer a suggestion to the user to help them enable Git to work with those WSL repos, aka git config --global --add safe.directory <path to repo>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds great! Currently, the UI in place is temporary. I will incorporate this feedback and gain more clarity around the design for surfacing user facing error messages in the expected UX.
tools/Customization/DevHome.FileExplorerSourceControlIntegration/Services/RepositoryTracking.cs
Show resolved
Hide resolved
tools/Customization/DevHome.FileExplorerSourceControlIntegration/Services/RepositoryTracking.cs
Outdated
Show resolved
Hide resolved
tools/Customization/DevHome.FileExplorerSourceControlIntegration/Services/RepositoryTracking.cs
Outdated
Show resolved
Hide resolved
tools/Customization/DevHome.FileExplorerSourceControlIntegration/Services/RepositoryTracking.cs
Outdated
Show resolved
Hide resolved
tools/Customization/DevHome.Customization/DevHome.Customization.csproj
Outdated
Show resolved
Hide resolved
tools/Customization/DevHome.Customization/ViewModels/FileExplorerViewModel.cs
Outdated
Show resolved
Hide resolved
tools/Customization/DevHome.Customization/Views/FileExplorerPage.xaml
Outdated
Show resolved
Hide resolved
tools/Customization/DevHome.Customization/Views/FileExplorerPage.xaml.cs
Outdated
Show resolved
Hide resolved
tools/Customization/DevHome.Customization/Views/FileExplorerPage.xaml
Outdated
Show resolved
Hide resolved
tools/Customization/DevHome.Customization/Views/FileExplorerPage.xaml.cs
Outdated
Show resolved
Hide resolved
tools/Customization/DevHome.Customization/Views/FileExplorerPage.xaml.cs
Outdated
Show resolved
Hide resolved
tools/Customization/DevHome.FileExplorerSourceControlIntegration/Services/RepositoryTracking.cs
Outdated
Show resolved
Hide resolved
...SourceControlIntegrationUnitTest/DevHome.FileExplorerSourceControlIntegrationUnitTest.csproj
Outdated
Show resolved
Hide resolved
...on/DevHome.FileExplorerSourceControlIntegrationUnitTest/RepositoryTrackingServiceUnitTest.cs
Show resolved
Hide resolved
tools/Customization/DevHome.FileExplorerSourceControlIntegration/Services/RepositoryTracking.cs
Show resolved
Hide resolved
tools/Customization/DevHome.FileExplorerSourceControlIntegration/Services/RepositoryTracking.cs
Show resolved
Hide resolved
32e55b0
into
feature/fileexplorer-sourcecontrol-integration
…ntrol extensions inside Dev Home (#2984) * changes to write/read data (extension information + root path) from json * address PR comments * revert line endings * address PR comments
…ntrol extensions inside Dev Home (#2984) * changes to write/read data (extension information + root path) from json * address PR comments * revert line endings * address PR comments
…ntrol extensions inside Dev Home (#2984) * changes to write/read data (extension information + root path) from json * address PR comments * revert line endings * address PR comments
Summary of the pull request
This PR contains the changes required to store and retrieve data from a json file required for source control integration.
References and relevant issues
Detailed description of the pull request / Additional comments
The code changes included are:
Validation steps performed
PR checklist