Making text wrap on Add Widget dialog #3009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krschau
approved these changes
May 30, 2024
tools/Dashboard/DevHome.Dashboard/Views/AddWidgetDialog.xaml.cs
Outdated
Show resolved
Hide resolved
vineeththomasalex
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
This PR has some changes to make text wrapping on the "Add Widget" dialog, fixing an accessibility issue for when the text is too large to fit the width and the content is clipped.
References and relevant issues
https://dev.azure.com/microsoft/OS/_workitems/edit/49360580
Detailed description of the pull request / Additional comments
There are two types of
NavigationViewItemin this dialog: the extension titles and the widget titles. The extension titles are only a text. Changing the content label to be aTextBlockinstead of plain text allows us to wrap it.For the widget titles, it was a
StackPanelbecause of it consisting of a image and a text, which is not capable of wrapping. This was changed to aGridwith two columns, and the content of the text column have a "star" width size. This way, the text inside it is also set to wrap and the content is now fully visible even when text scale is at 200%.Validation steps performed
Example in 100% size (before and after):
Example in 200% size (before and after):
PR checklist