Re-add creation failure error notifications to the environments page #3149
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
I noticed when there is an error during the creation operation we don't tell the user in the latest preview and canary versions of Dev Home. Its due to our previous update to the landing page where we make all compute systems that are being created appear at the top of the list on the environments page.
To do that we added them to the top of the list of ComputeSystemCardBase items in the environments page. However, prior to that change we just added them to the end of the list and then had the last added item in the list subscribe to the environments landing page's
OnComputeSystemOperationError
event. So, when we did the change to add them at the top of the list we missed updating the line of code that also subscribes the newly added view model to theOnComputeSystemOperationError
event. So, this change now makes sure that we subscribe to this event when the view model is created. Note: without subscribing to the event, the failure notification doesn't appear on the page.Another thing I added was updating the text that appears in the card as the compute system is being created to show this failure as well.
Before changes:
notifications.when.there.was.an.error.creating.environment.-.before.mp4
After changes:
notifications.when.there.was.an.error.creating.environment.mp4
References and relevant issues
Detailed description of the pull request / Additional comments
Validation steps performed
PR checklist