Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve DSC summary view loading performance #3397

Merged
merged 6 commits into from
Jul 24, 2024
Merged

Improve DSC summary view loading performance #3397

merged 6 commits into from
Jul 24, 2024

Conversation

AmelBawa-msft
Copy link
Contributor

@AmelBawa-msft AmelBawa-msft commented Jul 10, 2024 •
edited
Loading

Summary of the pull request

  • Before this code change, DSC summary view took several seconds to load because the details are fetched from source (e.g. PSGallery) for each unit.
  • After this change, the DSC summary view is loaded right away, and the details will be fetched in the background and displayed once ready.
Before (page loads slowly) After (page loads quickly)

References and relevant issues

Detailed description of the pull request / Additional comments

Validation steps performed

PR checklist

@AmelBawa-msft AmelBawa-msft marked this pull request as ready for review July 10, 2024 19:20
@AmelBawa-msft AmelBawa-msft added the Needs-Second Pull request that needs another approval label Jul 22, 2024
@krschau krschau removed the Needs-Second Pull request that needs another approval label Jul 24, 2024
@AmelBawa-msft AmelBawa-msft merged commit 6ce663a into main Jul 24, 2024
4 checks passed
@AmelBawa-msft AmelBawa-msft deleted the user/amelbawa/2561 branch July 24, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krschau krschau krschau approved these changes

@vineeththomasalex vineeththomasalex vineeththomasalex approved these changes

@dhoehna dhoehna dhoehna approved these changes

@AgneLukoseviciute AgneLukoseviciute Awaiting requested review from AgneLukoseviciute

@EricJohnson327 EricJohnson327 Awaiting requested review from EricJohnson327

@bbonaby bbonaby Awaiting requested review from bbonaby

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Configuration UI seems unresponsive on loading yaml
4 participants
@AmelBawa-msft @dhoehna @vineeththomasalex @krschau