-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand the list of file types for external tools #3406
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhoehna
reviewed
Jul 11, 2024
dhoehna
reviewed
Jul 11, 2024
dhoehna
reviewed
Jul 11, 2024
dhoehna
approved these changes
Jul 11, 2024
timkur
reviewed
Jul 11, 2024
timkur
reviewed
Jul 11, 2024
jaholme
reviewed
Jul 11, 2024
jaholme
reviewed
Jul 11, 2024
jaholme
approved these changes
Jul 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
Added explicit support for .bat, .cmd, .ps1, .msc files, and implicit support for any file type (only known file types were tested).
Updated the ExternalTool.Invoke method to return a Process instead of a bool. This will be useful later when we provide features to work with the launched process. As part of this, switched from explorer.exe to ApplicationActivationManager for launching packaged apps by AUMID - now invoking all tool types can return a Process (except for protocol activations).
Made the tool path textbox editable - so the user can simply type in a path instead of opening the file dialog, if they wish.
Additional comments
Validation steps performed
Tested registering/invoking:
PR checklist