Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling selection on enter, not movement. #3468

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

dhoehna
Copy link
Contributor

@dhoehna dhoehna commented Jul 19, 2024

Summary of the pull request

Previous implementation used an ItemsView to get an accented border around an environment. A result is that moving between the environments with the arrows also selected the environment.

This change uses a list view to

  1. Get the blue pill
  2. Enables selection when the enter key is pressed and only when the enter key is pressed.

References and relevant issues

https://task.ms/50553395

Detailed description of the pull request / Additional comments

Validation steps performed

PR checklist

  • Closes #xxx
  • Tests added/passed
  • Documentation updated

Movie!
UsingListViews

@bbonaby
Copy link
Contributor

bbonaby commented Jul 24, 2024

For this one, if we're moving towards using a listview I think we should do 2 things:

  1. Make a bug in the Win UI 3 repo to see if this is a bug in the items view control or if it'd be considered a feature request (which would probably mean it'd be on the backlog for a long time).
  2. We'd need to update the padding and margins for the listview, because based on the video it looks a bit off when an item is selected. I think Christian would end up filling a bug for that if we leave it this way.

@dhoehna dhoehna marked this pull request as draft July 24, 2024 17:43
@dhoehna
Copy link
Contributor Author

dhoehna commented Jul 24, 2024

Changed to Draft because the Items aren't aligned with the header. This is because the ListView adds left-padding to make space for the pill.

@dhoehna
Copy link
Contributor Author

dhoehna commented Jul 24, 2024

Waiting for Design to look over it.

@dhoehna
Copy link
Contributor Author

dhoehna commented Jul 24, 2024

@bbonaby

see if this is a bug
What bug? ItemsView did not have a bug.

@bbonaby
Copy link
Contributor

bbonaby commented Jul 24, 2024

@bbonaby

see if this is a bug
What bug? ItemsView did not have a bug.

Oh I meant as in, maybe the ItemsView control isn't suppose to auto select the list item on key up/down but instead act like the listview and not auto select on key up/down.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants