Fix duplicate class ids #3535
Merged
Fix duplicate class ids #3535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DefaultRyan
requested changes
Aug 5, 2024
There was a problem hiding this comment.
Remember to update:
- common/Helpers/CommonConstants.cs
- tools/Customization/DevHome.FileExplorerSourceControlIntegration/SourceControlProvider.cs
Without that we won't be able to register the proper classID with explorer, and the COM server won't respond to activation requests.
DefaultRyan
approved these changes
Aug 5, 2024
ssparach
merged commit 1d1395c
into
feature/fileexplorer-sourcecontrol-integration
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
The class ids for SourceControlIntegration.exe were not modified for the different manifest versions. This modifies the class ids to be different.
References and relevant issues
Detailed description of the pull request / Additional comments
Validation steps performed
Local Build of msix package (release)
PR checklist