-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Navigation from experimental feature to the related page #3595
Conversation
] | ||
], | ||
"openPage": { | ||
"key": "DevHome.Customization.ViewModels.MainPageViewModel" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just thinking out loud for the future. If we implement a protocol processor in Dev Home to help us navigate between pages and activate Dev Home with a protocol to perform certain actions (e.g. something like ms-devhome://{page}?{params}). We may be able to use that here as well and maintain a single implementation. Or both can also co-exist as long as the engine processing the two interfaces is the same.
#NoActionRequired
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should have caught this in the spec, so I apologize for asking for this change, but instead of the "open in new window" button we should be using the IsClickEnabled/Command built into the settings card to do the navigation.
#2909 (comment)
Ooh agreed, I don't love that. @TWhiteDesigns, thoughts? I'm not sure where on the spectrum of "kind of annoying" to "shockingly difficult" it would be to nudge the toggle over to match in cases where the > icon doesn't show. If it's not bad, I'd suggest that. |
@davidegiacometti I think this looks great, let's do it! |
33aded3
to
86d3340
Compare
I have addressed the feedback and updated the screenshot in the PR description. A small nit I noticed on Windows 10 related to experimental feature: Quiet background processes and File Explorer source control integrations aren't available. The first experimental feature is totally hidden, but, the second one is visible only in the list. |
Good catch. Quiet background processes showing up was fixed by #3545, but I opened #3679 to fix File Explorer integration. |
Summary of the pull request
Added navigation from experimental feature to the related page.
References and relevant issues
#2909
Detailed description of the pull request / Additional comments
NavConfig.jsonc
: added page key/parameter for opening the experimental feature related page.Validation steps performed
PR checklist