Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation from experimental feature to the related page #3595

Merged
merged 5 commits into from
Aug 22, 2024

Conversation

davidegiacometti
Copy link
Contributor

Summary of the pull request

Added navigation from experimental feature to the related page.

References and relevant issues

#2909

Detailed description of the pull request / Additional comments

  • Changed NavConfig.jsonc: added page key/parameter for opening the experimental feature related page.
  • Added a button to open the experimental feature page in experimental feature settings.
  • Handled navigation in pages in order to show QuickstartPlayground and FileExplorer view.

dev

Validation steps performed

  • Manually tested the navigation for the 4 existing experimental feature.
  • Validated that the "Open" button is rendered as expected after switching dark/light theme.

PR checklist

]
],
"openPage": {
"key": "DevHome.Customization.ViewModels.MainPageViewModel"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just thinking out loud for the future. If we implement a protocol processor in Dev Home to help us navigate between pages and activate Dev Home with a protocol to perform certain actions (e.g. something like ms-devhome://{page}?{params}). We may be able to use that here as well and maintain a single implementation. Or both can also co-exist as long as the engine processing the two interfaces is the same.

#NoActionRequired

Copy link
Collaborator

@krschau krschau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have caught this in the spec, so I apologize for asking for this change, but instead of the "open in new window" button we should be using the IsClickEnabled/Command built into the settings card to do the navigation.
#2909 (comment)

@davidegiacometti
Copy link
Contributor Author

Don't worry Kristen, changes make sense and also look better. 😃

image

I don't really like the misaligned toggle switches for disabled features 😞
WDYT?

@krschau
Copy link
Collaborator

krschau commented Aug 15, 2024

I don't really like the misaligned toggle switches for disabled features 😞 WDYT?

Ooh agreed, I don't love that. @TWhiteDesigns, thoughts?

I'm not sure where on the spectrum of "kind of annoying" to "shockingly difficult" it would be to nudge the toggle over to match in cases where the > icon doesn't show. If it's not bad, I'd suggest that.

@davidegiacometti
Copy link
Contributor Author

Easy to do using DataTriggerBehavior + ChangePropertyAction 😃
Here is a screen of the proposed solution.

image

@krschau
Copy link
Collaborator

krschau commented Aug 16, 2024

Easy to do using DataTriggerBehavior + ChangePropertyAction 😃 Here is a screen of the proposed solution.

@davidegiacometti I think this looks great, let's do it!

@davidegiacometti
Copy link
Contributor Author

I have addressed the feedback and updated the screenshot in the PR description.

A small nit I noticed on Windows 10 related to experimental feature: Quiet background processes and File Explorer source control integrations aren't available. The first experimental feature is totally hidden, but, the second one is visible only in the list.

@krschau
Copy link
Collaborator

krschau commented Aug 22, 2024

I have addressed the feedback and updated the screenshot in the PR description.

A small nit I noticed on Windows 10 related to experimental feature: Quiet background processes and File Explorer source control integrations aren't available. The first experimental feature is totally hidden, but, the second one is visible only in the list.

Good catch. Quiet background processes showing up was fixed by #3545, but I opened #3679 to fix File Explorer integration.

@krschau krschau merged commit 1fbadf0 into microsoft:main Aug 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Experimental feature toggle cards in Dev home Settings should contain link to feature "home"
4 participants