Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix possible crash navigating away from Dashboard #3619

Merged
merged 1 commit into from
Aug 16, 2024
Merged

Fix possible crash navigating away from Dashboard #3619

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tools/Dashboard/DevHome.Dashboard/Views/DashboardView.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ private async Task OnLoadedAsync()
private async Task OnUnloadedAsync()
{
_log.Debug($"Unloading Dashboard, cancel any loading.");
_initWidgetsCancellationTokenSource.Cancel();
_initWidgetsCancellationTokenSource?.Cancel();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's still a race condition because InitializeDashboard() does some amount of non-trivial work before initializing _initWidgetsCancellationTokenSource. So it's possible that we could see this sequence:

  • OnLoadedAsync() called, InitializeDashboard() starts running, _initWidgetsCancellationTokenSource still null.
  • OnUnloadedAsync() called, _initWidgetsCancellationTokenSource still null, so no call to Cancel().
  • InitializeDashboard() finally reaches the point where it initializes _initWidgetsCancellationTokenSource, but because OnUnloadedAsync() is already finished, the cancellation never gets called.

Is there a reason we don't simply initialize the cancellation token in the constructor, so even in this case InitializeDashboard will eventually see the cancellation?

ViewModel.PinnedWidgets.CollectionChanged -= OnPinnedWidgetsCollectionChangedAsync;
Bindings.StopTracking();

Expand Down
Loading